Fix loading pauses between chapters when preloading is enabled - #110
Open
PoonHarpoon wants to merge 1 commit into
Open
Fix loading pauses between chapters when preloading is enabled#110PoonHarpoon wants to merge 1 commit into
PoonHarpoon wants to merge 1 commit into
Conversation
Member
|
Alright let me test all your PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Preload pages enabled, pages ahead of your current position are loaded in advance. Previously,
that preload request could run before the next chapter's page list was available. When the list arrived,
the reader added it without requesting another preload. You could read smoothly through the current chapter,
then reach the next one and have to wait for its first images to load.
This change requests preloading as soon as the next chapter's page list has been added, giving its first
images time to load while you finish the current chapter. Moving into the next chapter therefore feels much
smoother: its images can already be ready instead of starting to load as you reach them. The benefit depends
on how quickly you read and how quickly the source delivers the images.
It uses the existing Preload pages setting and its network, battery, memory, cache, and queue limits.
Only pages from the immediately following chapter are selected, and chapters already loaded are skipped.
I compiled the APK and tested it on my phone and an emulator; both are working as expected.
Tests added to check behavior is consistent.