Skip to content

worker.sh: don't abort when the AppImage is self-hosted - #3823

Merged
probonopd merged 1 commit into
AppImage:masterfrom
budbrain-software:fix-worker-self-hosted-abort
Aug 2, 2026
Merged

worker.sh: don't abort when the AppImage is self-hosted#3823
probonopd merged 1 commit into
AppImage:masterfrom
budbrain-software:fix-worker-self-hosted-abort

Conversation

@budbrain-software

Copy link
Copy Markdown
Contributor

Fixes #3822.

Both assignments lack the || true that lines 500, 501 and 506 carry. With bash -e (see .github/workflows/test.yml) a grep that finds nothing ends the whole run.

The branch is only reached when the data file holds no https://github.com/ URL — i.e. exactly for self-hosted AppImages, which therefore can never pass the check.

Same class of bug as #3678, fixed there in 86a5b18 the same way.

@probonopd
probonopd merged commit e8762da into AppImage:master Aug 2, 2026
@probonopd

Copy link
Copy Markdown
Member

Thank you very much @budbrain-software

budbrain-software added a commit to budbrain-software/appimage.github.io that referenced this pull request Aug 3, 2026
The previous run failed on the worker.sh bug fixed in PR AppImage#3823 (merged 2026-08-02). No change to the catalog entry; this empty commit only restarts the check against current master.
budbrain-software added a commit to budbrain-software/appimage.github.io that referenced this pull request Aug 3, 2026
The previous run failed on the worker.sh bug fixed in PR AppImage#3823 (merged 2026-08-02). No change to the catalog entry; this empty commit only restarts the check against current master.
budbrain-software added a commit to budbrain-software/appimage.github.io that referenced this pull request Aug 3, 2026
The previous run failed on the worker.sh bug fixed in PR AppImage#3823 (merged 2026-08-02). No change to the catalog entry; this empty commit only restarts the check against current master.
budbrain-software added a commit to budbrain-software/appimage.github.io that referenced this pull request Aug 3, 2026
The previous run failed on the worker.sh bug fixed in PR AppImage#3823 (merged 2026-08-02). No change to the catalog entry; this empty commit only restarts the check against current master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

worker.sh: missing || true aborts every self-hosted AppImage

2 participants