Baseline dependency and dead code cleanup - #39
Merged
Conversation
OpenAPISpecCall (in OpenAPI-REST-Tests) references PetsAPI, which is defined in OpenAPI-Core-Tests - but the baseline only declared OpenAPI-REST as a requirement. This worked only by accident because the default Tests group happens to load all three Tests packages together; loading OpenAPI-REST-Tests on its own would fail to resolve PetsAPI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
convert:contentType:/convertApplicationJson:/convertTextPlain: were never called from anywhere in the codebase. The actual response- parsing path is OAResponse>>handleResponse: (used by OpenApiClient>>handleResponse:), which dispatches to OAMediaTypeObject>>handleResponse: instead - a separate, unrelated method despite the similar name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.