feat(gui): polish device and pointer visuals - #495
Merged
Conversation
AprilNEA
marked this pull request as ready for review
August 2, 2026 18:50
Greptile SummaryThis PR polishes device and pointer visuals without changing device behavior.
Confidence Score: 5/5The PR appears safe to merge, with no concrete behavioral, build, or security defects identified in the changed GUI paths. The referenced icon assets are registered, existing built-in icon call sites are preserved through equivalent Icon construction, and the remaining changes are localized presentation and control-component updates with no established broken behavior.
|
| Filename | Overview |
|---|---|
| crates/openlogi-gui/src/app/detail.rs | Adds bounded device-name truncation and supplies distinct typed icons to pointer and device cards. |
| crates/openlogi-gui/src/app/home.rs | Adds a persistent active-card border and dims the complete device image and lighting layer while offline. |
| crates/openlogi-gui/src/app/widgets.rs | Generalizes panel-card helpers to accept configured Icon values while preserving existing built-in icons. |
| crates/openlogi-gui/src/components/dpi_panel.rs | Replaces the DPI preset removal div with the standard extra-small ghost button and enlarges the adjacent apply target. |
Reviews (1): Last reviewed commit: "feat(gui): polish device and pointer vis..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish device selection and pointer settings so active, offline, and interactive states read more clearly without changing device behavior.
Changes
Testing
devenv tasks run openlogi:checkcargo test -p openlogi-gui— 52 passedFixes: N/A (no linked issue)