Skip to content

feat(gui): polish device and pointer visuals - #495

Merged
AprilNEA merged 1 commit into
masterfrom
feat/ui-polish
Aug 2, 2026
Merged

feat(gui): polish device and pointer visuals#495
AprilNEA merged 1 commit into
masterfrom
feat/ui-polish

Conversation

@AprilNEA

@AprilNEA AprilNEA commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

Polish device selection and pointer settings so active, offline, and interactive states read more clearly without changing device behavior.

Changes

  • GUI
    • give the active device card a persistent accent ring and tint
    • dim the complete device render, including cached lighting, while offline
    • truncate long device names before they crowd the detail tabs
    • use distinct gauge, SmartShift, and mouse icons for the pointer cards
    • replace the DPI preset remove hit target with the standard button component

Testing

  • devenv tasks run openlogi:check
  • cargo test -p openlogi-gui — 52 passed
  • visually checked Home, Buttons, and Pointer screens with four discovered devices in the dev app
  • device setting writes were not runtime-tested on hardware

Fixes: N/A (no linked issue)

@AprilNEA
AprilNEA marked this pull request as ready for review August 2, 2026 18:50
@greptile-apps

greptile-apps Bot commented Aug 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR polishes device and pointer visuals without changing device behavior.

  • Adds a persistent accent treatment for the active device and dims offline device renders.
  • Truncates long device names in the detail header.
  • Introduces distinct icons for pointer-related cards.
  • Replaces the DPI preset removal target with a standard compact button.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete behavioral, build, or security defects identified in the changed GUI paths.

The referenced icon assets are registered, existing built-in icon call sites are preserved through equivalent Icon construction, and the remaining changes are localized presentation and control-component updates with no established broken behavior.

Important Files Changed

Filename Overview
crates/openlogi-gui/src/app/detail.rs Adds bounded device-name truncation and supplies distinct typed icons to pointer and device cards.
crates/openlogi-gui/src/app/home.rs Adds a persistent active-card border and dims the complete device image and lighting layer while offline.
crates/openlogi-gui/src/app/widgets.rs Generalizes panel-card helpers to accept configured Icon values while preserving existing built-in icons.
crates/openlogi-gui/src/components/dpi_panel.rs Replaces the DPI preset removal div with the standard extra-small ghost button and enlarges the adjacent apply target.

Reviews (1): Last reviewed commit: "feat(gui): polish device and pointer vis..." | Re-trigger Greptile

@AprilNEA
AprilNEA merged commit ccf9330 into master Aug 2, 2026
17 checks passed
@AprilNEA
AprilNEA deleted the feat/ui-polish branch August 2, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant