Skip to content

chore: cleanup tests classes#3948

Merged
robfrank merged 1 commit intomainfrom
chore/cleanup-assertj
Apr 21, 2026
Merged

chore: cleanup tests classes#3948
robfrank merged 1 commit intomainfrom
chore/cleanup-assertj

Conversation

@robfrank
Copy link
Copy Markdown
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.

Additional Notes

Anything else we should know when reviewing?

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank merged commit 6b9b6be into main Apr 21, 2026
6 of 12 checks passed
@robfrank robfrank deleted the chore/cleanup-assertj branch April 21, 2026 20:41
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 21, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

🟢 Coverage ∅ diff coverage · -8.15% coverage variation

Metric Results
Coverage variation -8.15% coverage variation
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f6afe41) 118511 86868 73.30%
Head commit (577048b) 149750 (+31239) 97565 (+10697) 65.15% (-8.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3948) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on cleaning up and modernizing the test suite across multiple modules. Key changes include renaming test methods to remove the redundant 'test' prefix, updating exception handling in test signatures to use a generic Exception, and adjusting class and method visibility to package-private to align with JUnit 5 best practices. Additionally, it migrates several tests from JUnit 4 to JUnit 5, replaces legacy assertions with AssertJ, and removes several unused shell scripts. I have no feedback to provide as the changes are consistent improvements to the codebase.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.28%. Comparing base (f6afe41) to head (577048b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3948      +/-   ##
==========================================
- Coverage   64.34%   64.28%   -0.07%     
==========================================
  Files        1586     1586              
  Lines      118511   118511              
  Branches    25179    25179              
==========================================
- Hits        76255    76179      -76     
- Misses      31673    31777     +104     
+ Partials    10583    10555      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robfrank robfrank added this to the 26.4.1 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant