feat: ignore configured paths in affected analysis - #5
Merged
Conversation
calvin-archastro
force-pushed
the
feat/affected-ignore
branch
from
July 21, 2026 16:27
4adc983 to
48dcf8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds an explicit workspace-level
[affected].ignoreconfiguration for excluding repository-relative Git paths before Aster maps changes to projects.The filter is applied once, immediately after committed and working-tree changes are collected. The same filtered path set now drives project ownership, verbose diagnostics, dry-run file rationale, and
--only-affected-files, preventing ignored metadata from leaking into later execution decisions.Untracked-directory traversal now reports leaf files so fine-grained patterns such as
.agents/**/*.mdbehave consistently. Malformed workspace TOML and invalid affected-ignore globs return contextual errors instead of silently disabling configuration.The watch integration harness now launches Aster in its own Unix process group. Aster intentionally terminates its process group during shutdown; without test isolation, non-interactive CI shells shared that group and were canceled when the test sent SIGTERM to the child.
Runtime flow
sequenceDiagram participant CLI participant Config participant Git participant Filter participant Ownership CLI->>Config: Load workspace configuration Config-->>CLI: Return affected ignore patterns CLI->>Git: Collect changed paths Git-->>CLI: Return committed and working tree paths CLI->>Filter: Remove paths matching configured globs alt Paths remain Filter-->>Ownership: Forward filtered paths Ownership-->>CLI: Return affected projects else Every path is ignored Filter-->>CLI: Return empty path set CLI-->>CLI: Report no projects affected endType relationships
classDiagram class WorkspaceConfig { +AffectedWorkspaceConfig affected } class AffectedWorkspaceConfig { +Vec~String~ ignore } class AffectedIgnore { -GlobSet patterns +build config +is_ignored path +filter paths } class AffectedDetector { +all_affected_files base head +uncommitted_changes } class AffectedCommand { +map filtered paths +run target } WorkspaceConfig *-- AffectedWorkspaceConfig AffectedIgnore ..> AffectedWorkspaceConfig : builds from AffectedCommand --> AffectedDetector : collects paths AffectedCommand --> AffectedIgnore : filters pathsScope
CLI, Rust library, and integration-test harness only. No service, frontend, database, API, or infrastructure changes.
The diff is one cohesive feature; more than half is focused integration coverage for ownership, dry-run, files-list, rename, untracked-path, and process-cleanup behavior.
Risk assessment
Low to medium. The new configuration is opt-in, so existing valid workspaces retain their current affected-project behavior. Workspace TOML that was already malformed now fails with a clear error instead of silently falling back to defaults. Untracked directories are traversed to leaf files, which improves accuracy but may expose more precise paths to existing affected analysis.
The process-group change is test-only and Unix-gated; non-Unix behavior retains the existing child-kill fallback.
User impact
Repositories can prevent metadata-only or generated-file changes from triggering unrelated project builds:
Ignored paths no longer appear in verbose output, dry-run rationale, or file-scoped target arguments.
Testing
cargo fmt --all -- --checkcargo test— 397 unit tests, 58 integration tests, and 3 active watch tests passed; 12 timing/real-monorepo tests intentionally ignoredcargo clippy --test watch_tests -- -D warningscargo clippy --all-targets— passed with pre-existing warnings onlyFollow-ups and known issues
Firstlanding still needs to adopt the released Aster version, configure its shared-skill paths, and fix its CI gate to derive
has_affectedfrom parsed project addresses rather than non-empty human-readable output.