fix: pass archive_results=[] to LiveBusUI.print_summary() in _run_install - #1826
Merged
Conversation
…tall abx-dl updated LiveBusUI.print_summary() to require archive_results as a keyword-only argument, causing TypeError at the end of archivebox init --install after all binaries had already installed successfully. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1825
abx-dlupdatedLiveBusUI.print_summary()to requirearchive_resultsas a keyword-only argument, but_run_installinrunner.pywasn't updated to match. This caused aTypeErrorat the end ofarchivebox init --installafter all binaries had already installed successfully — the install itself completed fine, only the summary display crashed.Fix: pass
archive_results=[]since the install path has no archive results.Summary by cubic
Fixes a crash at the end of
archivebox init --installby passingarchive_results=[]toLiveBusUI.print_summary()in_run_install. Aligns with the new keyword-only signature inabx-dl, so installs complete and the summary renders without error.Written for commit c28e3a9. Summary will update on new commits.