Skip to content

File icons improvement#537

Merged
pirate merged 2 commits intoArchiveBox:masterfrom
TrAyZeN:master
Nov 19, 2020
Merged

File icons improvement#537
pirate merged 2 commits intoArchiveBox:masterfrom
TrAyZeN:master

Conversation

@TrAyZeN
Copy link
Copy Markdown
Contributor

@TrAyZeN TrAyZeN commented Nov 14, 2020

Summary

This PR fixes the order of file icons and changes the opacity of file icons on the public view.

Related issues

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

@cdvv7788
Copy link
Copy Markdown
Contributor

@TrAyZeN you will need to change your PR to be based on #525 . That PR changes a lot of internal stuff, including the way the icons are included.

@pirate
Copy link
Copy Markdown
Member

pirate commented Nov 14, 2020

I'm going to close this because I prefer the old order because it's ordered from most useful -> least useful (grouped by extractor dependency type), and the DOM dump is one of the worst snapshot formats in terms of reliability.

I appreciate the time though and thank you for submitting a PR nonetheless.

@pirate pirate closed this Nov 17, 2020
@TrAyZeN
Copy link
Copy Markdown
Contributor Author

TrAyZeN commented Nov 18, 2020

Sorry for answering that late, I didn't know there was a prefered order but this PR was not about the order. The problem was that the icons were not corresponding to the links. For instance, when you clicked on the 💻 icon it would link to html dump instead of screenshot.

@pirate pirate reopened this Nov 19, 2020
@pirate
Copy link
Copy Markdown
Member

pirate commented Nov 19, 2020

Ah, thanks for clarifying, I didn't see that earlier 👍

@pirate pirate merged commit afe9319 into ArchiveBox:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants