Skip to content

Replace Link with Snapshot (WIP)#593

Closed
cdvv7788 wants to merge 27 commits intoArchiveBox:v0.5.0from
cdvv7788:link-removal
Closed

Replace Link with Snapshot (WIP)#593
cdvv7788 wants to merge 27 commits intoArchiveBox:v0.5.0from
cdvv7788:link-removal

Conversation

@cdvv7788
Copy link
Copy Markdown
Contributor

Summary

Use Snapshot everywhere, instead of the old Link schema. This is a work in progress, and most likely unstable at this point.

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

@cdvv7788 cdvv7788 changed the base branch from dev to v0.5.0 December 29, 2020 17:14
@cdvv7788
Copy link
Copy Markdown
Contributor Author

Extractors are working using snapshot only. Pending:

  • HTML index is disabled at the moment. Refactor pending
  • All of the parsers (except the base txt one) are still using link
  • The generated index detail may be inconsistent with previous versions. Need to check this in detail before proceeding
  • Only add and init commands tested so far. Need to work on the other commands.

@cdvv7788
Copy link
Copy Markdown
Contributor Author

cdvv7788 commented Dec 31, 2020

Most commands are functional now. There are issues with what some of them return, but they don't raise any issue when running them:

  • Add is still using parsers that require links
  • Init is not correctly recreating the folders that are not in the main index but are in the filesystem
  • Status is not displaying the right status for everything
  • Server is returning a 500 error (with nothing being shown in the console)

Fixing these issues is what I am working on at the moment.

@cdvv7788
Copy link
Copy Markdown
Contributor Author

cdvv7788 commented Jan 4, 2021

The most obvious issues are fixed now. All of the commands are partially functional. Now I will focus on:

  • Getting the tests running
  • Restore the html-related functionalities
  • Find a good way to handle tags with the new structure
  • Make sure that the index is correct when compared with the previous version

Comment thread archivebox/parsers/pocket_api.py
@pirate pirate closed this Jan 6, 2021
@pirate pirate deleted the branch ArchiveBox:v0.5.0 January 6, 2021 18:02
@pirate
Copy link
Copy Markdown
Member

pirate commented Jan 8, 2021

Whoops closing this was not intentional, it auto-closed when v0.5.0 was deleted after merging. @cdvv7788 do you mind re-opening this against dev (and any other of your PRs that were against v0.5.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants