Fix warm binary request cache hits - #44
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
pirate
added a commit
to ArchiveBox/ArchiveBox
that referenced
this pull request
Sep 1, 2026
## Summary - make `archivebox list --html` write every snapshot detail page from the same `core/snapshot.html` Django template used for live admin site - create canonical UUID detail directories for pending/unarchived snapshots too, without embedding live admin routes - omit stale/nonexistent output targets, suppress bogus `/None` icons, and correctly URL-encode literal `%` filenames - create non-TTY crawl progress reporters and relay supervised worker output on stderr so JSONL stdout stays valid - replace both public-site Docker examples of `init --install` with plain `init` and remove their false install output Closes #1847. ## Issue reproduction Built 0.9.35rc352 from source, ran a fresh Docker collection with only `archivebox init`, then archived `https://sweeting.me/` at depth 1. The completed collection has 75 snapshots, 14.0 GB, and only canonical `archive/users/system/snapshots/<date>/<domain>/<uuid>/` roots鈥攝ero legacy timestamp directories. Before this PR, the exported index linked to 75 missing snapshot detail pages. After the fix, it contains 76 static HTML pages total. A filesystem-aware HTML traversal checked 11,286 local href/src targets: zero missing and zero live `/snapshot`, `/web`, or `/static` routes. ## Verification - `archivebox/tests/test_cli_list.py`: 23 passed - `archivebox/tests/test_ui_admin_snapshot.py`: 61 passed - crawl runner + CLI piping suites: 37 passed - changed-file prek hooks: passed - real non-TTY Docker add emitted process STARTED and succeeded rows while preserving stdout/stderr separation - unarchived-snapshot regression starts with a missing output directory and proves export creates a portable detail page with no live admin URL ## Dependency PRs - ArchiveBox/abx-dl#18 supplies the shared non-TTY lifecycle renderer - ArchiveBox/abxpkg#44 fixes the warm installer cache identity/version bugs found during this reproduction No installer concurrency or skip branches were added. The non-Docker development/CLI `init --install` examples and its real fuzz test are intentionally unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the root cache misses behind repeated ArchiveBox plugin installation checks. It does not add skip logic or parallelize the ordered installer.
Root causes
Verification
..path, never enter_load/varvs/private/varassertions also fail unchanged on pristine main