Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS_Mavlink: Make rssi adhere to MAVLink standard #3 #18435

Merged
merged 4 commits into from
Aug 25, 2021

Conversation

olliw42
Copy link
Contributor

@olliw42 olliw42 commented Aug 24, 2021

continuation of #18244

all done as suggested, rebased, cleaned up, etc

the question which scaling to choose has unfortunately still not been finally decided

for your convenience, I recall #18244 (comment), which was

concerning scaling, we talk about two scenarios, in my understanding:

scenario A:

rssi = read_receiver_rssi() * 255;
return (rssi < 255) ? rssi : 254;

scenario B:

return read_receiver_rssi() * 254;

In scenario A, the rssi values would be equal across the different telemetries (and logs?)(and support tools), except of 255 which is excluded, i.e. the range of 0 ... 254 would not exactly be 0 ... 1, but only 0 ... 0.9961

In scenario B the rssi would be 0.39% smaller than different telemetries (and logs?)(and support tools), but the range of 0 ... 254 would exactly correspond to 0 ... 1.

in this PR it is scenario A so far. Please tell/decide if that is OK or should be changed to scenario B.

libraries/GCS_MAVLink/GCS_Common.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants