pre-commit: Fix current errors #24727
Conversation
There was a problem hiding this comment.
Those commit messages are... not good.
Only one of them actually says what changed about the file, the others are "some tool told me to do this".
In the case of the line-endings changes, the fact that's not called out is a pretty big problem as the change is pretty bad as it is a significant change for the purpose of backporting bugfixes.
Should be seeing commit messages like "XXX: add shebang line to script" and "YYY: remove executable permissions" and "ZZZ: rename non-xml scrimmage template away from .xml".
Ryanf55
force-pushed
the
pre-commit-fix-current-errors
branch
from
206666d
to
e4f10a7
Compare
I changed all the commit messages to be much more descriptive. Makes sense. Tridge recommended we decided case-by-case on the line-ending ones. That said, it seems @khancyr already tried to change it before in 22dae61, but it's still triggering the pre-commit violation. Any idea why we need to do it again? |
Ryanf55
force-pushed
the
pre-commit-fix-current-errors
branch
from
e4f10a7
to
8ea9819
Compare
* This fixes an error in pre-commit's check-xml hook * Tools/autotest/template/scrimmage.xml: Failed to xml parse (Tools/autotest/template/scrimmage.xml:8:7: not well-formed (invalid token)) * Since it's a template file, it is not parseable as XML till after it's rendered by jinja Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* Source files are not supposed to be executable Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* Hex files should not be executable * .txt files should not be executable * The DDS test listener was supposed to be executable but was missing a shebang Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* Fixes a pre-commit violation; the ioc files are not supposed to be executable Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* This script was marked as executable but did not have a shebang Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* The Lua scripts are not directly invoked - they have no shebang, so they shouldn't be executable Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* This file had DOS line endings and ArduPilot uses UNIX endings * This fixes a pre-commit violation Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
peterbarker
force-pushed
the
pre-commit-fix-current-errors
branch
from
8ea9819
to
8d501e0
Compare
This fixes all current errors with pre-commit in ArduPilot. Relates to #24683
Mainly:
.j2extension which is common for jinja templates)