Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support preflight calibration ia command_int #24905

Merged

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Sep 7, 2023

I've stepped through the code which the new tests don't cover.

@peterbarker peterbarker force-pushed the pr/preflight-cals-as-command-int branch from 3c404c6 to 53b26e7 Compare September 7, 2023 10:16
@peterbarker
Copy link
Contributor Author

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       8      *           0       -8                16     -16    -8
HerePro             -56                                                                   
Hitec-Airspeed      *                                                                     
KakuteH7-bdshot                -64    *           -96     -88               -64    -96    -96
MatekF405                      -64    *           -80     -88               -56    -96    -80
Pixhawk1-1M-bdshot             -56                -80     -80               -56    -88    -80
f103-QiotekPeriph   *                                                                     
f303-Universal      *                                                                     
iomcu                                                           *                         
revo-mini                      -80    *           -88     -88               -64    -104   -104
skyviper-v2450                                    -80                                     

@peterbarker
Copy link
Contributor Author

I've had a look at the Copter/SkyViper-v2450 elf-diff:
image

image

image

image

... apparently is_equal is expensive?!

@peterbarker peterbarker force-pushed the pr/preflight-cals-as-command-int branch from d8d9ba6 to 3f2243f Compare September 13, 2023 02:59
@peterbarker peterbarker merged commit 219a13e into ArduPilot:master Sep 13, 2023
84 checks passed
@peterbarker peterbarker deleted the pr/preflight-cals-as-command-int branch September 13, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants