-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AP_GPS_ENABLED to exclude more code #25092
Use AP_GPS_ENABLED to exclude more code #25092
Conversation
8252bc5
to
49a11eb
Compare
Is there a way to make the github regression tests aware of these compile flags? It would be interresting to run the tests on configurations that have features disabled. |
Yes!
We do test some trivial examples of that based on See https://github.com/ardupilot/ardupilot/blob/master/.github/workflows/test_chibios.yml#L157 |
.... see also |
Nice, I guess I should be on the dev meetings more often. I missed that info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to run the full matrix check to ensure this doesn't break a board
@@ -12,7 +12,7 @@ | |||
#endif | |||
|
|||
#ifndef AP_GPS_DRONECAN_ENABLED | |||
#define AP_GPS_DRONECAN_ENABLED HAL_ENABLE_DRONECAN_DRIVERS | |||
#define AP_GPS_DRONECAN_ENABLED AP_GPS_BACKEND_DEFAULT_ENABLED && HAL_ENABLE_DRONECAN_DRIVERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we run the full matrix check on this? this could break a board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Of all of the boards that compile, all changes are explained (changed on-board hwdef)
a9d7eef
to
91d376d
Compare
91d376d
to
8cb3467
Compare
Board AP_Periph blimp bootloader copter heli iofirmware plane rover sub
Durandal * * * * * * *
HerePro *
Hitec-Airspeed *
KakuteH7-bdshot * * * * * * *
MatekF405 16 * 16 8 8 16 8
Pixhawk1-1M-bdshot * * * * * *
f103-QiotekPeriph *
f303-Universal *
iomcu *
revo-mini * * * * * * *
skyviper-v2450 *