Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AP_GPS_ENABLED to exclude more code #25092

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Sep 25, 2023

Board AP_Periph blimp bootloader copter heli iofirmware plane rover sub
Durandal * * * * * * *
HerePro *
Hitec-Airspeed *
KakuteH7-bdshot * * * * * * *
MatekF405 16 * 16 8 8 16 8
Pixhawk1-1M-bdshot * * * * * *
f103-QiotekPeriph *
f303-Universal *
iomcu *
revo-mini * * * * * * *
skyviper-v2450 *


This work sponsored by Spektreworks

@peterbarker peterbarker force-pushed the pr/more-AP_GPS_ENABLED branch 2 times, most recently from 8252bc5 to 49a11eb Compare September 25, 2023 10:03
@amilcarlucas
Copy link
Contributor

Is there a way to make the github regression tests aware of these compile flags?

It would be interresting to run the tests on configurations that have features disabled.

@peterbarker
Copy link
Contributor Author

Is there a way to make the github regression tests aware of these compile flags?

Yes! build_options.py does that.

It would be interresting to run the tests on configurations that have features disabled.

We do test some trivial examples of that based on build_options.py.

See https://github.com/ardupilot/ardupilot/blob/master/.github/workflows/test_chibios.yml#L157

@peterbarker
Copy link
Contributor Author

It would be interresting to run the tests on configurations that have features disabled.

.... see also test_build_options.py which tests a lot of things based on build_options.py - enabling each option in turn, disabling each option in turn , enabling all, enabling none and enabling defaults... it takes a while to run :-)

@amilcarlucas
Copy link
Contributor

Nice, I guess I should be on the dev meetings more often. I missed that info.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to run the full matrix check to ensure this doesn't break a board

@@ -12,7 +12,7 @@
#endif

#ifndef AP_GPS_DRONECAN_ENABLED
#define AP_GPS_DRONECAN_ENABLED HAL_ENABLE_DRONECAN_DRIVERS
#define AP_GPS_DRONECAN_ENABLED AP_GPS_BACKEND_DEFAULT_ENABLED && HAL_ENABLE_DRONECAN_DRIVERS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we run the full matrix check on this? this could break a board

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Of all of the boards that compile, all changes are explained (changed on-board hwdef)

@peterbarker peterbarker force-pushed the pr/more-AP_GPS_ENABLED branch 2 times, most recently from a9d7eef to 91d376d Compare September 26, 2023 11:06
@peterbarker peterbarker merged commit 8cfdf10 into ArduPilot:master Sep 27, 2023
84 checks passed
@peterbarker peterbarker deleted the pr/more-AP_GPS_ENABLED branch September 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants