Plane: send attitude target message implementation (for quadplanes) #25253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this copes with the M10S rejecting multiple-key VALGET calls. We fall back to fetching one at a time
Co-authored-by: Randy Mackay <rmackay9@yahoo.com> optional support to toggle GPIO pin at 10hz
this sets up the vwd integrator more reasonably when we are in POSITION1 stage of VTOL landing. We need to have enough throttle to cope with a headwind, but want it lower when we are at or above our target closing speed so can minimise the amount of pitch up This also makes the landing_desired_closing_velocity() consistent with the landing speed used in approach, using average of airspeed min and cruise speed if TECS_LAND_ARSPD is not set The target airspeed for TECS during airbraking is now set to ARSPD_FBW_MIN, on the basis we are trying to slow down to min speed, and we have VTOL support which should prevent a stall. To cope with a high headwind where ARSPD_FBW_MIN is below the headwind we now check for too low achieved closing speed and switch to POSITION1 which can use vfwd to get to the landing location
M10S (no storage) throws this for a considerable period of time and the wording makes this process sound scary.
The ResetVelocity() function is only supposed to reset XY states, not Z state. Resetting the Z state for velocity results in a large velocity glitch if a vehicle is descending or ascending when aiding switches to AID_NONE this fixes ArduPilot#19386
The ResetVelocity() function is only supposed to reset XY states, not Z state. Resetting the Z state for velocity results in a large velocity glitch if a vehicle is descending or ascending when aiding switches to AID_NONE this fixes ArduPilot#19386
this test was relying on the EKF bug fixed in this PR. The copter was actually fully landing and touching the ground in the LAND phase whereas the original intention of this test was that it not touch the ground in LAND. See the graph in ArduPilot#17104 where the test was added
… increases flash usage
miodine
force-pushed
the
Plane-4.4-mods
branch
from
26102d7
to
32d7fad
Compare
|
I did as it was requested - I applied the most recent suggestions, reverted any chages done in the logging part, and squashed the commits altogether. |
IamPete1
approved these changes
Oct 16, 2023
|
@miodine I have marked for the dev cal which is this evening on Discord, your welcome to come along. https://ardupilot.org/dev/docs/ardupilot-discord-server.html#weekly-dev-calls |
|
All right, then I'll await the results of your discussion. Sorry for my clumsiness with all that, and thanks for the guidance |
miodine
changed the title
tridge
requested changes
Oct 17, 2023
| } | ||
|
|
||
| const Quaternion quat = plane.quadplane.attitude_control->get_attitude_target_quat(); | ||
| const Vector3f ang_vel = plane.quadplane.attitude_control->get_attitude_target_ang_vel(); |
|
this needs to be against master, not plane-4.4 |
|
@IamPete1 will rework this as a PR against master |
Minor modification - implementation of the send_attitude_target msg. streaming (for quadplanes). The code is analogous in its structure and functionality to the implementation in Copter Co-Authored-By: Peter Hall <33176108+IamPete1@users.noreply.github.com>
miodine
force-pushed
the
Plane-4.4-mods
branch
from
f1556b1
to
3394d1a
Compare
miodine
force-pushed
the
Plane-4.4-mods
branch
from
3394d1a
to
fb87369
Compare
…into Plane-4.4-mods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor mod to the communication routine, whose purpose is to expose the target attitude for a plane operating in VTOL mode.
Might be useful for external in-flight PID tuning applications.