AP_RangeFinder: fix Lua timeout #26829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
rishabsingh3003
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Hi,
Thank you so much for this. The changes look correct to me. The driver seems to have been broken by: #25641
I am currently travelling so don't have access to my rangefinders. I'll be back in a couple of days, and will test a few rangefinder drivers that we have that make use of the lua backend to ensure everything is working.
|
I have tested this branch with my TOFSENSE -M serial driver for which we already have a Lua driver. It works as expected. I also confirmed it is not working on Master. |
|
@rmackay9 can we get this merged? |
tridge
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the timeout test from
AP_RangeFinder_Lua::handle_script_msgback toAP_RangeFinder_Lua::update. This should revert the behavior to what folks are seeing in Copter 4.4, prior to 2cc63f5.The timeout is still set to 500ms.