Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arming check for duplicate scripting RC channels and extra RC checks for rover-quiktune #27133

Merged
merged 1 commit into from
May 23, 2024

Conversation

stephendade
Copy link
Contributor

@stephendade stephendade commented May 22, 2024

Fixing two (related) issues in here, from a user support session:

  1. The arming check for duplicate RC Aux functions didn't check for Scripting functions, as it only checked for Aux function with an ID <256 (Scripting was 300+)
    2. Added an extra check in the rover-quiktune script to warn the user if they had a mis-configured (or no) RC channel mapped to scripting

@rmackay9
Copy link
Contributor

Hi @stephendade,

Thanks for all the investigation and fix for the issue.

Re the Rover quiktune change, doesn't this mean that if the user has not setup an RC switch to "scripting1" and instead uses Mission Planner's Aux Function tab (this is shown on the Rover QuikTune wiki page) that they will see an error until they first push the "Low" button?

@stephendade
Copy link
Contributor Author

Re the Rover quiktune change, doesn't this mean that if the user has not setup an RC switch to "scripting1" and instead uses Mission Planner's Aux Function tab (this is shown on the Rover QuikTune wiki page) that they will see an error until they first push the "Low" button?

Ahh, wasn't aware of that function. I'll remove that check.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any bigger and we'll need to change to the N**2 algorithm here.

@peterbarker peterbarker merged commit d16ff40 into ArduPilot:master May 23, 2024
91 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants