ci: make go-cve gate blocking (remove continue-on-error) - #84
Merged
Conversation
govulncheck ./... is clean under Go 1.26.4 (0 reachable vulnerabilities; 19 stdlib CVEs were in go1.25.4 stdlib, all fixed by ≥go1.25.11 and included in go1.26.4 which is already pinned in go/go.mod since 51133b4). Remove continue-on-error: true from go-cve so the scan is now a hard gate on all PRs to main/dev. go test ./... and go vet ./... remain green under Go 1.26.4.
This was referenced Jul 9, 2026
release: bump Go toolchain 1.26.4 → 1.26.5 to clear the GO-2026-5856 CVE gate (only red on dev)
#138
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: truefrom thego-cvejob sogovulncheck ./...is a hard gate on PRs tomain/dev.Why now
go/go.modwas already bumped togo 1.26.4andgolang.org/x/net v0.55.0in 51133b4. Runninggovulncheck ./...under Go 1.26.4 (matching CIsetup-go) reports 0 reachable vulnerabilities — the 19 stdlib CVEs previously found were all ingo1.25.4stdlib (fixed by ≤go1.25.11, included ingo1.26.4). The gate is now safe to harden.Verification
All run under Go 1.26.4.