Final Diffstarpop model - #106
Merged
Merged
Conversation
…gslope model for the scaling relations of the mean ecrit and qtime parameters
Contributor
|
How does this PR relate to #105? |
Collaborator
Author
|
It's the same, but cleaner. #105 has a couple of model variations, called ecrit and ecrit_qt. This PR directly updates the default diffstarpop files, i.e. |
Collaborator
Author
|
So we can close #105. |
…h the scripts used to create the target data for the Diffstarpop paper.
… the mah and creating the time table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates DiffstarPop to the final model used in the paper, which uses the sigslope model for the scaling relations of the mean ecrit and qtime parameters.
The main files updated are the
sfh_pdf_mgash.pykernel file, and the best fit diffstar and diffstarpop fits parameter files. The DEFAULT_DIFFSTARPOP_PARAMS are taken fromsfh_pdf_mgash.py, which match the best-fit diffstarpop params of UniverseMachine (no merging).