API pagination issues

[dated]

When the passed page value is bigger than the pageCount property the API still sets the previous property

https://explorer.ark.io/api/v2/delegates/dated/voters?page=100

{
  "meta": {
    "count": 0,
    "pageCount": 1,
    "totalCount": 52,
    "next": null,
    "previous": "/api/v2/delegates/dated/voters?page=99&limit=100",
    "self": "/api/v2/delegates/dated/voters?page=100&limit=100",
    "first": "/api/v2/delegates/dated/voters?page=1&limit=100",
    "last": "/api/v2/delegates/dated/voters?page=1&limit=100"
  },
  "data": []
}

pageCount and totalCount change value based on the passed page param

https://explorer.ark.io/api/v2/wallets/cryptology/transactions/received?page=2

{ pageCount: 1, totalCount: 100 }

https://explorer.ark.io/api/v2/wallets/cryptology/transactions/received?page=3

// correct values?

{ pageCount: 3, totalCount: 233 }

https://explorer.ark.io/api/v2/wallets/cryptology/transactions/received?page=4

// from here onwards:
// pageCount = page - 1
// totalCount = (page - 1) * 100

{ pageCount: 3, totalCount: 300 }

https://explorer.ark.io/api/v2/wallets/cryptology/transactions/received?page=1000

{ pageCount: 999, totalCount: 99900 }

@dated Thanks for opening this issue, a maintainer will get back to you shortly!

@air1one @faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[dated]

Some more info for you, @faustbrian

[dated]

Using a limit the pagination doesn't work beyond the first 100 records in some occasions:

https://explorer.ark.io/api/v2/wallets/dated/transactions?page=4&limit=25

(Missing next)

[faustbrian]

@dated can you check if 51240b3 resolved the issue or if further changes are needed?

[vasild]

Two different problems are reported in this issue. @dated, it is better to report each problem as a separate github issue.
The first problem is not fixed yet.

[Nigui]

Will be fixed soon or not prioritized ?

[faustbrian]

Not a priority right now as the main issues are resolved if you switch your node to using counts instead of estimates, which can be configured since 2.5.

The When the passed page value is bigger than the pageCount property the API still sets the previous property issue still remains and probably needs a fix in the pagination package itself but isn't high priority.