Remove custom wallet repository#3534
Closed
rainydio wants to merge 1 commit intofeature/segregated-poolfrom
Closed
Remove custom wallet repository#3534rainydio wants to merge 1 commit intofeature/segregated-poolfrom
rainydio wants to merge 1 commit intofeature/segregated-poolfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/segregated-pool #3534 +/- ##
========================================================
Coverage 48.71% 48.72%
========================================================
Files 539 539
Lines 13387 13386 -1
Branches 1798 1797 -1
========================================================
Hits 6522 6522
+ Misses 6836 6835 -1
Partials 29 29 Continue to review full report at Codecov.
|
rainydio
deleted the
refactor/core-transactions/wallet-repository-isolation
branch
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Segregated pool doesn't pass custom wallet repository as argument. It isn't needed anymore.
This is draft, so I can check that tests do run fine on CI. Because @sebastijankuzner is working on core-transactions test coverage, I will try to merge his changes here occasionally.
Checklist