Skip to content

Conversation

@alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Oct 11, 2021

Summary

https://app.clickup.com/t/11m1a5u

Before:
image

After:
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't resolve it for inline code, see for example this on the same page as the codeblock:
image

@ItsANameToo
Copy link
Member

@alexbarnsley please check if inline code rendering can also work with html entities, because using <div> in the markdown there would result in actual divs being constructed

@ItsANameToo ItsANameToo marked this pull request as draft October 11, 2021 14:01
@alexbarnsley
Copy link
Member Author

@ItsANameToo I missed the inline ones. They use a separate renderer, that should now be covered now. I've also included a unit test to make sure the content is parsed correctly for block and inline

Before:
image

After:
image

@alexbarnsley alexbarnsley marked this pull request as ready for review October 11, 2021 16:44
@ItsANameToo ItsANameToo merged commit 26ac652 into main Oct 12, 2021
@ItsANameToo ItsANameToo deleted the refactor/code-block-decode-html-entities branch October 12, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants