refactor: consolidate heading classes and use tailwind layers #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crnkovic
commented
Dec 7, 2022
resources/assets/css/_components.css
Outdated
Comment on lines
12
to
14
| .rich-select-dropdown-entry:not(.rich-select-dropdown-entry-selected):not(.rich-select-dropdown-entry-hover) { | ||
| .rich-select-dropdown-entry:not(.rich-select-dropdown-entry-selected):not( | ||
| .rich-select-dropdown-entry-hover | ||
| ) { |
| .navbar-container { | ||
| @apply px-10; | ||
| } | ||
| @apply px-8 md:px-10; |
Contributor
Author
There was a problem hiding this comment.
replaced the @screen with md:px-10
Comment on lines
-26
to
+20
| @apply font-bold text-theme-secondary-900; | ||
| } | ||
|
|
||
| h1 { | ||
| @apply font-bold; | ||
| } | ||
|
|
||
| .dark h1, | ||
| .dark h2, | ||
| .dark h3, | ||
| .dark h4 { | ||
| @apply text-theme-secondary-200; | ||
| @apply font-bold text-theme-secondary-900 dark:text-theme-secondary-200 leading-tight; |
Contributor
Author
There was a problem hiding this comment.
additional font-bold on h1 was unnecessary. also .dark h1 can be replaced with dark:text-theme...
Comment on lines
-45
to
+28
| @apply font-bold text-theme-secondary-900; | ||
| } | ||
|
|
||
| .header-1 { | ||
| @apply font-bold text-theme-secondary-900; | ||
| } | ||
|
|
||
| .dark header-1, | ||
| .dark header-2, | ||
| .dark header-3, | ||
| .dark header-4 { | ||
| @apply text-theme-secondary-200; | ||
| @apply font-bold text-theme-secondary-900 dark:text-theme-secondary-200 leading-tight; |
Contributor
Author
There was a problem hiding this comment.
same as with .dark h1...
| h1, | ||
| .header-1 { | ||
| @apply text-3xl mb-1; | ||
| @apply text-3xl mb-1 md:text-4xl md:mb-2; |
Contributor
Author
There was a problem hiding this comment.
replaced @screen with this
| h1, | ||
| .header-1 { | ||
| @apply text-4xl mb-2; | ||
| @layer base { |
Contributor
Author
There was a problem hiding this comment.
pushed core styles to base layer
| .rotate-180 { | ||
| transform: rotate(180deg); | ||
| } | ||
| @layer utilities { |
Contributor
Author
There was a problem hiding this comment.
pushed clear-transform and rotate-minus-90 to utilities layer. though they may not be even used in any of the projects, i wouldn't remove them here now
ItsANameToo
approved these changes
Jan 13, 2023
ItsANameToo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/2u58u58
Checklist
icons.htmlfile and checked if my newly added icon is shown correctly (if necessary)