Skip to content

Conversation

@alfonsobries
Copy link
Member

@alfonsobries alfonsobries commented Oct 1, 2021

Summary

https://app.clickup.com/t/1ja2vuk

Dependant of https://github.com/ArkEcosystem/marketsquare.io/pull/2266

Updates the commonmark library to load the extensions again and adjust some extensions that has conflicts with this new version

To test:

  • Merge this on this PR
  • Create some stuff with markdown, you can create a new article on nova for example (news accept most of the custom plugins since everything is whitelisted)
  • Ensure the content is parsed as expected.
  • Especially focus on custom plugins like embed tweets, youtube videos, links, etc

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@faustbrian faustbrian merged commit 5da4f65 into main Oct 2, 2021
@faustbrian faustbrian deleted the fix/commonmark-extensions branch October 2, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants