refactor: move serialized test data to fixtures

tests/transactions/deserializers/test_delegate_registration.py

@@ -2,9 +2,7 @@
 
 
 def test_delegate_registration_deserializer(transaction_type_2):
-    serialized = transaction_type_2['serialized']
-
-    deserializer = Deserializer(serialized)
+    deserializer = Deserializer(transaction_type_2['serialized'])
     actual = deserializer.deserialize()
 
     assert actual.version == transaction_type_2['version']

tests/transactions/deserializers/test_delegate_resignation.py

@@ -2,9 +2,7 @@
 
 
 def test_delegate_resignation_deserializer(transaction_type_7):
-    serialized = transaction_type_7['serialized']
-
-    deserializer = Deserializer(serialized)
+    deserializer = Deserializer(transaction_type_7['serialized'])
     actual = deserializer.deserialize()
 
     assert actual.version == transaction_type_7['version']

tests/transactions/deserializers/test_multi_payment.py

@@ -1,25 +1,23 @@
 from crypto.transactions.deserializer import Deserializer
 
 
-def test_multi_payment_deserializer():
-    serialized = 'ff011e0100000006000500000000000000023efc1da7f315f3c533a4080e491f32cd4219731cef008976c3876539e1f192d3809698000000000000020000e1f505000000006f0182a0cc707b055322ccf6d4cb6a5aff1aeb2200c2eb0b00000000b693449adda7efc015d87944eae8b7c37eb1690a6031b2c73de394a12b4988f43f0fe13cd7782469857914b92e6c05561ff6d7634783a89157e487dc38f104bf40fc279c38602dbfba0cc679dfe631ba4c77929c'  # noqa
-
-    deserializer = Deserializer(serialized)
+def test_multi_payment_deserializer(transaction_type_6):
+    deserializer = Deserializer(transaction_type_6['serialized'])
     actual = deserializer.deserialize()
 
-    assert actual.version == 1
-    assert actual.network == 30
-    assert actual.typeGroup == 1
-    assert actual.type == 6
-    assert actual.nonce == 5
-    assert actual.senderPublicKey == '023efc1da7f315f3c533a4080e491f32cd4219731cef008976c3876539e1f192d3'
-    assert actual.fee == 10000000
-    assert actual.amount == 0
-    assert actual.asset['payments'][0]['amount'] == 100000000  # noqa
-    assert actual.asset['payments'][0]['recipientId'] == '0x6F0182a0cc707b055322CcF6d4CB6a5Aff1aEb22'  # noqa
-    assert actual.asset['payments'][1]['amount'] == 200000000  # noqa
-    assert actual.asset['payments'][1]['recipientId'] == '0xb693449AdDa7EFc015D87944EAE8b7C37EB1690A'  # noqa
-    assert actual.signature == '6031b2c73de394a12b4988f43f0fe13cd7782469857914b92e6c05561ff6d7634783a89157e487dc38f104bf40fc279c38602dbfba0cc679dfe631ba4c77929c'
-    assert actual.id == '46799c223ff8f19d00c3e3bd617c6692f3cab1aed33dbc99ad9706d22f709c5e'
+    assert actual.version == transaction_type_6['version']
+    assert actual.network == transaction_type_6['network']
+    assert actual.typeGroup == transaction_type_6['typeGroup']
+    assert actual.type == transaction_type_6['type']
+    assert actual.nonce == transaction_type_6['nonce']
+    assert actual.senderPublicKey == transaction_type_6['senderPublicKey']
+    assert actual.fee == transaction_type_6['fee']
+    assert actual.amount == transaction_type_6['amount']
+    assert actual.signature == transaction_type_6['signature']
+    assert actual.id == transaction_type_6['id']
+
+    for index, payment in enumerate(transaction_type_6['asset']['payments']):
+        assert actual.asset['payments'][index]['amount'] == payment['amount']
+        assert actual.asset['payments'][index]['recipientId'] == payment['recipientId']
 
     actual.verify_schnorr()

tests/transactions/deserializers/test_multi_signature_registration.py

@@ -1,32 +1,23 @@
 from crypto.transactions.deserializer import Deserializer
 
 
-def test_multi_signature_registration_deserializer():
-    serialized = 'ff011e0100000004000500000000000000023efc1da7f315f3c533a4080e491f32cd4219731cef008976c3876539e1f192d30065cd1d00000000000203029fab3cb2f5e248ae7cbb4de646741da4d73c493b2a03ab5c71507fb2c0dcca9203629f9dbf7f1e91cefa845126189816ceae357bdd1f41bd14787318a7d5b55d48027941d2059f89a26d89e87d3385e261a0ede1234aaeaa487012b69d6b67962dc504aee2652b4a41350b9821c261bb0a3c3492146a6e0ebda4e28a185d6c2e9eb7702b4889e8b9b5fadd989e71dbb7527b3be071e15cf3a93165e8f1b8c7b16974008c7c7018082d9afddd70652f559377a941240cf797819fe02f657d4509c8bcb133156741163cfb8e9b4db6ef398bdd5f94a24e1f0134d04783391bc13370201b015306973b045d83191ce57c56f097b79c0771a94310ee67aed8b96e1bb7f497e451fe569c297a857f840f46b801534179e87a5e07015fb03727746be450e925d6021d03e19f1e39ac9b985b867e8362002df387fd778a682218bc3e6ce4b5c7f59eaa6f893ffb8deec2e4c9b28287417e2ab7b427356ca74d790f7fb63b6f8dcbd5'  # noqa
-
-    deserializer = Deserializer(serialized)
+def test_multi_signature_registration_deserializer(transaction_type_4):
+    deserializer = Deserializer(transaction_type_4['serialized'])
     actual = deserializer.deserialize()
-    data = actual.to_dict()
 
-    assert data['amount'] == 0
-    assert data['nonce'] == 5
-    assert data['version'] == 1
-    assert data['network'] == 30
-    assert data['typeGroup'] == 1
-    assert data['fee'] == 500000000
-    assert data['senderPublicKey'] == '023efc1da7f315f3c533a4080e491f32cd4219731cef008976c3876539e1f192d3'
-    assert data['signature'] == '04aee2652b4a41350b9821c261bb0a3c3492146a6e0ebda4e28a185d6c2e9eb7702b4889e8b9b5fadd989e71dbb7527b3be071e15cf3a93165e8f1b8c7b16974'
-    assert data['id'] == '75affed80fcad541787fd673fafa6b90561feac2d3f4a2dae857641109c44787'
-    assert data['asset']['multiSignature']['min'] == 2
-    assert data['asset']['multiSignature']['publicKeys'] == [
-        '029fab3cb2f5e248ae7cbb4de646741da4d73c493b2a03ab5c71507fb2c0dcca92',
-        '03629f9dbf7f1e91cefa845126189816ceae357bdd1f41bd14787318a7d5b55d48',
-        '027941d2059f89a26d89e87d3385e261a0ede1234aaeaa487012b69d6b67962dc5'
-    ]
-    assert data['signatures'] == [
-        '008c7c7018082d9afddd70652f559377a941240cf797819fe02f657d4509c8bcb133156741163cfb8e9b4db6ef398bdd5f94a24e1f0134d04783391bc13370201b',  # noqa
-        '015306973b045d83191ce57c56f097b79c0771a94310ee67aed8b96e1bb7f497e451fe569c297a857f840f46b801534179e87a5e07015fb03727746be450e925d6',  # noqa
-        '021d03e19f1e39ac9b985b867e8362002df387fd778a682218bc3e6ce4b5c7f59eaa6f893ffb8deec2e4c9b28287417e2ab7b427356ca74d790f7fb63b6f8dcbd5'  # noqa
-    ]
+    assert actual.version == transaction_type_4['version']
+    assert actual.network == transaction_type_4['network']
+    assert actual.typeGroup == transaction_type_4['typeGroup']
+    assert actual.type == transaction_type_4['type']
+    assert actual.nonce == transaction_type_4['nonce']
+    assert actual.senderPublicKey == transaction_type_4['senderPublicKey']
+    assert actual.fee == transaction_type_4['fee']
+    assert actual.amount == transaction_type_4['amount']
+    assert actual.signature == transaction_type_4['signature']
+    assert actual.id == transaction_type_4['id']
+
+    assert actual.asset['multiSignature']['min'] == transaction_type_4['asset']['multiSignature']['min']
+    assert actual.asset['multiSignature']['publicKeys'] == transaction_type_4['asset']['multiSignature']['publicKeys']
+    assert actual.signatures == transaction_type_4['signatures']
 
     actual.verify_multisig_schnorr()

tests/transactions/deserializers/test_transfer.py

@@ -1,24 +1,21 @@
-import pytest
 from crypto.transactions.deserializer import Deserializer
 
 
-def test_transfer_deserializer():
-    serialized = 'ff011e0100000000000300000000000000023efc1da7f315f3c533a4080e491f32cd4219731cef008976c3876539e1f192d38096980000000000000100000000000000000000006f0182a0cc707b055322ccf6d4cb6a5aff1aeb221c9e1c2493b1e597d682f31700989f76eec068375d4ce5e1721cc9265b66c9b551ea1afa28c4f443120e43cff5cc7f137c4572749b0467561038127b4eafded9'
-
-    deserializer = Deserializer(serialized)
+def test_transfer_deserializer(transaction_type_0):
+    deserializer = Deserializer(transaction_type_0['serialized'])
     actual = deserializer.deserialize()
 
-    assert actual.version == 1
-    assert actual.network == 30
-    assert actual.typeGroup == 1
-    assert actual.type == 0
-    assert actual.nonce == 3
-    assert actual.senderPublicKey == '023efc1da7f315f3c533a4080e491f32cd4219731cef008976c3876539e1f192d3'  # noqa
-    assert actual.fee == 10000000
-    assert actual.amount == 1
-    assert actual.expiration == 0
-    assert actual.recipientId == '0x6F0182a0cc707b055322CcF6d4CB6a5Aff1aEb22'
-    assert actual.signature == '1c9e1c2493b1e597d682f31700989f76eec068375d4ce5e1721cc9265b66c9b551ea1afa28c4f443120e43cff5cc7f137c4572749b0467561038127b4eafded9'
-    assert actual.id == '8d0584d1bbc8fa7a6e4e7904b884f69399df56dcfe6458c2bedc283c55604def'
+    assert actual.version == transaction_type_0['version']
+    assert actual.network == transaction_type_0['network']
+    assert actual.typeGroup == transaction_type_0['typeGroup']
+    assert actual.type == transaction_type_0['type']
+    assert actual.nonce == transaction_type_0['nonce']
+    assert actual.senderPublicKey == transaction_type_0['senderPublicKey']
+    assert actual.fee == transaction_type_0['fee']
+    assert actual.amount == transaction_type_0['amount']
+    assert actual.expiration == transaction_type_0['expiration']
+    assert actual.recipientId == transaction_type_0['recipientId']
+    assert actual.signature == transaction_type_0['signature']
+    assert actual.id == transaction_type_0['id']
 
     actual.verify_schnorr()