Correct suggestion descriptions and contrast display precision#10
Merged
Conversation
Artsen
marked this pull request as ready for review
July 25, 2026 21:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct two post-merge precision edge cases without reversing any behavior accepted in PR #9:
aria-describedbyBase commit:
15aa737bc4cb11f8bdf92d0dc90d74d939b2152dRoot causes
Suggestion generators attached strings that described requested intermediate HSL adjustments before range limits and RGB-to-HSL canonicalization. Those strings could therefore disagree with the returned color or state the wrong direction near minimum and maximum limits.
Contrast pass/fail used the calculated float, but
wcag_ratingserialized a two-decimal rounded ratio. A value immediately below 3.0, 4.5, or 7.0 could fail correctly while appearing equal to the threshold in the interface.The shell also used one
nullvalue for both metadata loading and failure, which could briefly show an unavailable state during normal startup.Suggestion corrections
percentage point(s)for saturation and lightness differences.commonAssociationsanduseCasesguidance contract from PR Align ColorCraft’s trust-sensitive copy and analysis behavior #9.Contrast precision corrections
formatContrastRatiofunction used by role checks, the advanced all-pairs matrix, and analysis-result displays.Network-status polish
The shell now models
loading,available, andunavailableseparately. Normal startup showsChecking network status; actual metadata failure showsNetwork status unavailable. Loopback and LAN explanations are attached witharia-describedbyinstead of relying on atitletooltip.Contract effects
There are no field additions, removals, or renames.
Behavioral response changes:
rationow retains calculated floating-point precision instead of a value rounded to two decimals.descriptionand, where necessary,namestrings now describe the final canonical returned color.Existing PR #9 contracts and behavior remain intact, including
commonAssociations, transitional temperature evidence, typed contrast roles, runtimenetworkMode, the 10 MB upload limit, and measured SVG label contrast.Validation
Passed the complete repository gate from the final committed LF-clean tree:
Additional validation:
git diff --check: passedthreshold - 0.0001, one scaled machine epsilon below, exactly at, and one scaled machine epsilon above 3.0, 4.5, and 7.0Remaining limitations