Add sql-custom back#592
Merged
Jason2605 merged 13 commits intoAsYetUntitled:masterfrom Dec 31, 2019
Merged
Conversation
Jason2605
added
enhancement
DomT602
previously approved these changes
Dec 31, 2019
Member
DomT602
left a comment
DomT602
left a comment
There was a problem hiding this comment.
Tested with Jason, seems good.
|
Should add in the east side, you already have 3 out of 4 sides. Might as well put them in. |
Member
This PR's purpose is to move to SQL Custom, replacing the old SQL Raw, the support for EAST would be done through a seperate PR otherwise it can get very hard to review and track changes. Once this PR is merged, feel free to start a PR to finish EAST support! |
DomT602
approved these changes
Dec 31, 2019
Member
DomT602
left a comment
DomT602
left a comment
There was a problem hiding this comment.
With recent fixes to gang disbandment, tested and works.
BoGuu
approved these changes
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Custom
Changes proposed in this pull request:
Note: This PR was made from #414 so there may be things missing, will leave it in a draft PR until we are more confident we have all the recent changes, and nothing is missing from the old merge.