Skip to content

fix(toolbar): restore toolbar key icon tint#117

Merged
AsafMah merged 1 commit into
devfrom
fix/toolbar-icon-tint
Jul 7, 2026
Merged

fix(toolbar): restore toolbar key icon tint#117
AsafMah merged 1 commit into
devfrom
fix/toolbar-icon-tint

Conversation

@AsafMah

@AsafMah AsafMah commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

Restores normal toolbar key icon/background tinting after the upstream v3.9.1 sync.

The sync introduced toolbar_key_background assignment and long-press hint wrapping in createToolbarKey(), but normal toolbar keys were no longer explicitly tinted after the drawable/background were assigned. State-key backgrounds still worked, but non-state toolbar icons could render with incorrect/default tint.

This PR reapplies the normal toolbar colors at key creation:

  • ColorType.TOOL_BAR_KEY for the icon
  • ColorType.TOOL_BAR_EXPAND_KEY_BACKGROUND for the toolbar-key background

Verification

  • ./gradlew.bat :app:assembleStandardfullDebug --no-daemon --console=plain passed

Blocker before merge

This is a visual regression fix and is not yet visually verified on device. Wireless adb disconnected before I could install and capture a screenshot.

Before merging:

  1. Install the rebuilt standardfullDebug APK on device.
  2. Open the keyboard toolbar.
  3. Capture/confirm toolbar icons/backgrounds look correct in the affected theme/state.
  4. Then mark this PR ready and merge.

Do not merge on build-only evidence.

@AsafMah AsafMah marked this pull request as ready for review July 7, 2026 19:52
@AsafMah AsafMah merged commit 9c0d013 into dev Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant