fix(input): restore fast Shift double-tap - #150
Merged
Conversation
Require a release boundary instead of an arbitrary 100 ms floor, preserving duplicate-press protection while allowing legitimate fast Caps Lock taps. Closes #146. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Exercise duplicate presses from shifted state and post-chord timing, and share the production double-tap timeout with the fake timer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #146
Test evidence
KeyboardStateTestcompleted 5 tests with 2 failures:fastDoubleTapShiftLocksCapsandduplicateShiftPressWithoutReleaseDoesNotLockCaps:app:testOfflineDebugUnitTest --tests '*KeyboardStateTest' --rerun-taskspassed all 8 testscompileOfflineRunTestsKotlinpassedParserTestfailures, 8 skipped;[ok] no new failures against baseline(--started-after 1788446191)Device verification
SM-S936B was unavailable: both
adb devices -landadb mdns serviceswere empty. Manual verification remains: