[fix] Bind Mooncake master RPC to configured host#136
Merged
Conversation
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Mooncake bootstrap command construction so mooncake_master binds its RPC listener to the configured host from master_server_address (via --rpc_address), not just the configured port. This aligns the bind address with the address clients use, fixing IPv6 deployments where binding defaulted to an IPv4 wildcard (0.0.0.0) and caused connection refusals.
Changes:
- Parse and extract
master_server_addresshostname intomaster_server_host. - Pass
--rpc_address=<master_server_host>alongside the existing--rpc_port=<port>when startingmooncake_master.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Mooncake bootstrap to pass the host from
master_server_addressintomooncake_mastervia--rpc_address, in addition to the existing--rpc_port.This fixes IPv6 deployments where mooncake_master previously bound RPC to the default
0.0.0.0, while clients connected through the IPv6 host configured inmaster_server_address, causing connection refused errors.