#156006054 Display collections to the user #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhallan
force-pushed
the
ft-display-collections-156006054
branch
from
5f63e42 to
fe236ad
Compare
Pull Request Test Coverage Report for Build #148
💛 - Coveralls |
- show new collections on the same page as the user adds them - show each collection is a card format - ensure the collections are clickable - implement the deleting of collections [Finishes #156006054]
- stop adding collections that have similar names by the same user - display an error message indicating the reason why one can't create the collection
muhallan
force-pushed
the
ft-display-collections-156006054
branch
from
fe236ad to
32da977
Compare
eric-elem
pushed a commit
that referenced
this pull request
Apr 9, 2018
* feat(collections): display collections to the user - show new collections on the same page as the user adds them - show each collection is a card format - ensure the collections are clickable - implement the deleting of collections [Finishes #156006054] * feat(collections): prevent duplicate collections - stop adding collections that have similar names by the same user - display an error message indicating the reason why one can't create the collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Displays the collections that a user has created and also enables him/her to create a new one
Description of Task to be completed?
How should this be manually tested?
Checkout to this branch and navigate to
/collectionsWhat are the relevant pivotal tracker stories?
#156006054
Screenshots (if appropriate)
Before deleting
After deleting some collections
Questions:
Why doesn't delete have a confirm dialog?