Skip to content

Conversation

@muhallan
Copy link
Collaborator

@muhallan muhallan commented Apr 4, 2018

What does this PR do?

Adds tests for the collections view

Description of Task to be completed?

Write comprehensive Python tests for the methods of the collections view

How should this be manually tested?

Checkout to this branch run pytest

Any background context you want to provide?

This is additional work that should have been in this PR #18

What are the relevant pivotal tracker stories?

#156006054

@muhallan muhallan requested review from Ashaba and eric-elem April 4, 2018 13:32
- write Python tests for the collections endpoint methods
[Delivers #156006054]
@muhallan muhallan force-pushed the ch-display-collections-tests-156006054 branch from fae213f to ed3932c Compare April 4, 2018 13:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build #153

  • 61 of 61 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 37.287%

Totals Coverage Status
Change from base Build #150: 0.4%
Covered Lines: 29182
Relevant Lines: 78263

💛 - Coveralls

Copy link
Owner

@Ashaba Ashaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@eric-elem eric-elem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-elem eric-elem merged commit 6d7871a into develop Apr 6, 2018
@eric-elem eric-elem deleted the ch-display-collections-tests-156006054 branch April 6, 2018 11:56
eric-elem pushed a commit that referenced this pull request Apr 9, 2018
- write Python tests for the collections endpoint methods
[Delivers #156006054]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants