Skip to content

Conversation

@nidin
Copy link
Contributor

@nidin nidin commented Jan 24, 2019

Extended _BinaryenAddMemoryImport and _BinaryenSetMemory functions with shared: bool argument
This will configure WASM memory as shared.

Extended `_BinaryenAddMemoryImport` and `_BinaryenSetMemory` functions with `shared: bool` argument
This will configure WASM memory as shared.
@dcodeIO
Copy link
Member

dcodeIO commented Jan 24, 2019

As a starting point it is ok to just append a , false where these functions are called, just to make the tests pass. Also please append yourself to the NOTICE file before I merge :)

@MaxGraey
Copy link
Member

For declarations I guess last param should be define as shared?: bool

@nidin
Copy link
Contributor Author

nidin commented Jan 24, 2019 via email

@nidin
Copy link
Contributor Author

nidin commented Jan 24, 2019 via email

@MaxGraey
Copy link
Member

MaxGraey commented Jan 24, 2019

I see. In this case need add additional and optional shared param for this methods:

  1. addMemoryImport(

  2. setMemory(

nidin added 2 commits January 25, 2019 10:37
Updated AssemblyScript contributions author list
`shared:bool` argument added to `addMemoryImport` and  `setMemory` functions
@nidin
Copy link
Contributor Author

nidin commented Jan 25, 2019

@dcodeIO @MaxGraey Ready for review

@dcodeIO dcodeIO merged commit b7c7be1 into AssemblyScript:master Jan 25, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Jan 25, 2019

Looking good, merging. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants