-
-
Notifications
You must be signed in to change notification settings - Fork 679
Added shared memory support in binaryen definition #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended `_BinaryenAddMemoryImport` and `_BinaryenSetMemory` functions with `shared: bool` argument This will configure WASM memory as shared.
Member
|
As a starting point it is ok to just append a |
Member
|
For declarations I guess last param should be define as |
Contributor
Author
|
It’s a C API. there is no optional arguments nor default value for the
argument, therefore it’s a breaking change.
…On Thu 24. Jan 2019 at 4:52 PM, Max Graey ***@***.***> wrote:
For declarations I guess last param should be define as shared?: bool
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#435 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMGZtqUQt2Js2OXc_c9KjSnWe8nbWVcks5vGdbBgaJpZM4aQup7>
.
|
Contributor
Author
|
May be JS API of binaryen will take it as false in the absence of this
argument.
…On Thu 24. Jan 2019 at 8:27 PM, 01Alchemist ***@***.***> wrote:
It’s a C API. there is no optional arguments nor default value for the
argument, therefore it’s a breaking change.
On Thu 24. Jan 2019 at 4:52 PM, Max Graey ***@***.***>
wrote:
> For declarations I guess last param should be define as shared?: bool
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#435 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAMGZtqUQt2Js2OXc_c9KjSnWe8nbWVcks5vGdbBgaJpZM4aQup7>
> .
>
|
Member
Updated AssemblyScript contributions author list
`shared:bool` argument added to `addMemoryImport` and `setMemory` functions
Contributor
Author
Member
|
Looking good, merging. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended
_BinaryenAddMemoryImportand_BinaryenSetMemoryfunctions withshared: boolargumentThis will configure WASM memory as shared.