Utilize new inlining utility to potentially inline any call#684
Merged
Utilize new inlining utility to potentially inline any call#684
Conversation
Member
Author
|
One side-product of this is that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in MaxGraey/as-bignum#20 the compiler didn't yet attempt to inline all possible call sites (while emitting an AS224 warning), but this should be possible now by using the utility introduced with the runtime branch. Essentially, whenever a call is inlined, the locals used in operands are blocked right-to-left so other temps don't conflict.