feat: 支持tg平台的部分引用 - #9380
Closed
10knamesmore wants to merge 1 commit into
Closed
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The prompt formatting for quoted messages (sender prefix plus either full text or
<selected_excerpt>tag) is now spread between_process_quote_messageand the Telegram adapter; consider extracting a small helper to build this quoted block so future changes to the tag format or sender display stay consistent across platforms. - In
_process_quote_message, when aselected_excerptis present you suppress the full quoted text entirely; if you expect users to sometimes want both focused and broader context, you might want to include the full text alongside the excerpt (or make this behavior configurable).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The prompt formatting for quoted messages (sender prefix plus either full text or `<selected_excerpt>` tag) is now spread between `_process_quote_message` and the Telegram adapter; consider extracting a small helper to build this quoted block so future changes to the tag format or sender display stay consistent across platforms.
- In `_process_quote_message`, when a `selected_excerpt` is present you suppress the full quoted text entirely; if you expect users to sometimes want both focused and broader context, you might want to include the full text alongside the excerpt (or make this behavior configurable).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
Hi, thanks for your contribution. #9236 already implemented this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7938
telegram平台 支持部分引用, 即引用整条消息的一部分, 接入这一点并让模型感知, 以便其可以精确定位到预期的消息中的某一段节选
Modifications / 改动点
AstrBot/astrbot/core/message/components.py:596的 Replay 增加了一个selected_excerpt字段, 表示引用中的部分内容AstrBot/astrbot/core/astr_main_agent.py:857如果存在selected_excerpt, 那么给模型的文本优先基于他渲染Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Support partial text quoting from Telegram and surface selected excerpts to the LLM when processing quoted messages.
New Features:
Enhancements:
Tests: