Skip to content

fix: prevent transient project session in ChatUI session list - #9587

Open
wcqqq1214 wants to merge 2 commits into
AstrBotDevs:masterfrom
wcqqq1214:fix/9567
Open

fix: prevent transient project session in ChatUI session list#9587
wcqqq1214 wants to merge 2 commits into
AstrBotDevs:masterfrom
wcqqq1214:fix/9567

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #9567. When a user starts a new conversation inside a project and sends its first message, the new session briefly appears in the general "Conversations" sidebar list while the AI is generating, then disappears after the reply completes. This only happens on the first message of a session.

Root cause: newSession() refreshed the session list (getSessions()) before the new session was associated with its project, so the backend still reported it in the general conversation list. When the stream ends the list is re-fetched with project sessions excluded, and the entry disappears.

Modifications / 改动点

  • dashboard/src/composables/useSessions.ts: Removed the premature await getSessions() from newSession(), so the list is no longer refreshed before the session is linked to its project.

  • dashboard/src/components/chat/Chat.vue: In sendCurrentMessage, added a single await getSessions() after session creation (and optional project association) completes. The list is now refreshed exactly once, with the session already in its final location — project sessions land directly under the project, regular sessions land in the "Conversations" area, and no transient state is rendered.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

Before / 修复前

Before — while the first reply is generating, the new session also appears in the general "Conversations" list below.

Screenshot 2026-08-06 at 13 50 32 Screenshot 2026-08-06 at 13 50 44

After / 修复后

After — the session now appears only under its project, and no longer appears in the general "Conversations" list while the first reply is generating.

Screenshot 2026-08-07 at 17 59 37 Screenshot 2026-08-07 at 18 01 55

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了"验证步骤"和"运行截图"

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Ensure newly created project sessions only appear under their project instead of briefly showing in the global conversations list while the first reply is generating.

Summary by Sourcery

Bug Fixes:

  • Prevent newly created project sessions from briefly appearing in the general conversations list before being associated with their project.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review August 7, 2026 10:24
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:webui The bug / feature is about webui(dashboard) of astrbot. feature:chatui The bug / feature is about astrbot's chatui, webchat labels Aug 7, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Moving getSessions() out of newSession() changes its side‑effects; please double‑check other callers of newSession() to ensure they still refresh the session list where needed, or document that callers are now responsible for doing so.
  • In sendCurrentMessage, consider guarding the await getSessions() call so it only runs when a new session was actually created, to avoid unnecessary list refreshes on follow‑up messages in an existing session.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Moving `getSessions()` out of `newSession()` changes its side‑effects; please double‑check other callers of `newSession()` to ensure they still refresh the session list where needed, or document that callers are now responsible for doing so.
- In `sendCurrentMessage`, consider guarding the `await getSessions()` call so it only runs when a new session was actually created, to avoid unnecessary list refreshes on follow‑up messages in an existing session.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. feature:chatui The bug / feature is about astrbot's chatui, webchat size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ChatUI: first message of a new session flickers in the sidebar conversation list and disappears after the AI finishes

1 participant