fix: prevent transient project session in ChatUI session list - #9587
Open
wcqqq1214 wants to merge 2 commits into
Open
fix: prevent transient project session in ChatUI session list#9587wcqqq1214 wants to merge 2 commits into
wcqqq1214 wants to merge 2 commits into
Conversation
wcqqq1214
marked this pull request as ready for review
August 7, 2026 10:24
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Moving
getSessions()out ofnewSession()changes its side‑effects; please double‑check other callers ofnewSession()to ensure they still refresh the session list where needed, or document that callers are now responsible for doing so. - In
sendCurrentMessage, consider guarding theawait getSessions()call so it only runs when a new session was actually created, to avoid unnecessary list refreshes on follow‑up messages in an existing session.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Moving `getSessions()` out of `newSession()` changes its side‑effects; please double‑check other callers of `newSession()` to ensure they still refresh the session list where needed, or document that callers are now responsible for doing so.
- In `sendCurrentMessage`, consider guarding the `await getSessions()` call so it only runs when a new session was actually created, to avoid unnecessary list refreshes on follow‑up messages in an existing session.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9567. When a user starts a new conversation inside a project and sends its first message, the new session briefly appears in the general "Conversations" sidebar list while the AI is generating, then disappears after the reply completes. This only happens on the first message of a session.
Root cause:
newSession()refreshed the session list (getSessions()) before the new session was associated with its project, so the backend still reported it in the general conversation list. When the stream ends the list is re-fetched with project sessions excluded, and the entry disappears.Modifications / 改动点
dashboard/src/composables/useSessions.ts: Removed the prematureawait getSessions()fromnewSession(), so the list is no longer refreshed before the session is linked to its project.dashboard/src/components/chat/Chat.vue: InsendCurrentMessage, added a singleawait getSessions()after session creation (and optional project association) completes. The list is now refreshed exactly once, with the session already in its final location — project sessions land directly under the project, regular sessions land in the "Conversations" area, and no transient state is rendered.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Before / 修复前
Before — while the first reply is generating, the new session also appears in the general "Conversations" list below.
After / 修复后
After — the session now appears only under its project, and no longer appears in the general "Conversations" list while the first reply is generating.
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了"验证步骤"和"运行截图"。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes: