fix: convert Telegram video notes into a Video component - #9627
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
video_notebranch duplicates much of the existingvideohandling; consider extracting a small helper to resolve the file and construct theComp.Videoso both code paths stay consistent and easier to maintain. - In the
video_notebranch you set bothfileandpathtofile.file_path; if regular videos use a different URL/Path scheme, it may be safer to reuse the same logic (e.g., using the same helper that builds a public file URL) so video notes behave identically in downstream components.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `video_note` branch duplicates much of the existing `video` handling; consider extracting a small helper to resolve the file and construct the `Comp.Video` so both code paths stay consistent and easier to maintain.
- In the `video_note` branch you set both `file` and `path` to `file.file_path`; if regular videos use a different URL/Path scheme, it may be safer to reuse the same logic (e.g., using the same helper that builds a public file URL) so video notes behave identically in downstream components.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Soulter
approved these changes
Aug 12, 2026
BegoniaHe
added a commit
to Xero-Team/AstrBot
that referenced
this pull request
Aug 12, 2026
Adapted from upstream 91ee487 (AstrBotDevs#9627).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Telegram video note, the round clip you record with the shortcut in the Telegram client, never makes it into the pipeline.
convert_message()dispatches on message type and the chain of branches stops atvideo: there is novideo_notebranch, so nothing matches andAstrBotMessage.messagegoes out as an empty list. The request is then dropped inagent_sub_stages/internal.py, wherehas_valid_message,has_media_contentandhas_replyare all false. The bot stays silent, and nothing further down the pipeline ever learns that a video arrived.Modifications / 改动点
astrbot/core/platform/sources/telegram/tg_adapter.py:video_notebranch, built like the existingvideobranch, producing aComp.Video.tests/fixtures/helpers.py:create_mock_update()takes avideo_noteargument.tests/test_telegram_adapter.py: one new case covering a video note becoming aComp.Video.Screenshots or Test Results / 运行截图或测试结果
Before the fix
The video note arrives and parses fine, and the dump shows the
video_notefield. Nothing is added to the chain, though, and the request is dropped atinternal:190without an error or a warning anywhere. On the client side the message simply looks sent; ask about it and the model says it never got a video.Log (before)
After the fix
The video note now produces a
Comp.Video,has_media_contentis true, and the request goes to the provider like any other video. Asked the same question, the model answers from the file it received.Log (after)
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Handle Telegram video note messages by converting them into standard video components so they flow through the pipeline like other media.
New Features:
Enhancements:
Tests: