Loop node implementation #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design for a new loop composite node that iterates until a break condition is met or max iterations is reached. Includes: - Do-while execution style - Parameter flow between iterations - Lineage tracking via separate branch logs per iteration - Argo compatibility via recursive templates Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Clarify that loop node branch parameter must always be a Pipeline, consistent with other composite nodes (parallel, map, conditional). Update SDK examples to wrap tasks in Pipeline objects. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add loop placeholder constant following MAP_PLACEHOLDER pattern for iteration index replacement in loop node names
- Rename _resolve_map_placeholders to _resolve_iter_placeholders - Add support for LOOP_PLACEHOLDER resolution - Handle nested map and loop placeholders correctly - Keep old method for backward compatibility Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
- Create LoopNode class following composite node patterns - Use LOOP_PLACEHOLDER for branch name generation - Add validation for break_on and index_as parameters - Implement _get_iteration_branch_name using refactored placeholder resolution Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
- Add get_break_condition_value() method with proper validation - Add _create_iteration_branch_log() using placeholder resolution - Add _build_iteration_iter_variable() for iteration context - Proper error handling for missing/invalid parameters - Add comprehensive tests for all new methods Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
- Create branch logs for current iteration - Copy parameters from parent (iteration 0) or previous iteration - Use proper placeholder resolution for branch names - Support both initial and subsequent iterations Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
- Check break condition and max iterations correctly - Roll back parameters to parent on loop exit - Set final step status based on branch execution - Extract current iteration from iter_variable properly Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.