Skip to content

feat(mcphub-nvim)!: Dont override opts - #1588

Merged
Uzaaft merged 1 commit into
AstroNvim:mainfrom
jay-babu:main
Jul 24, 2025
Merged

feat(mcphub-nvim)!: Dont override opts #1588
Uzaaft merged 1 commit into
AstroNvim:mainfrom
jay-babu:main

Conversation

@jay-babu

Copy link
Copy Markdown
Contributor

📑 Description

Remove custom options and use the defaults provided by the plugin: https://ravitemer.github.io/mcphub.nvim/configuration.html

ℹ Additional Information

@github-actions

github-actions Bot commented Jul 23, 2025

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@jay-babu

Copy link
Copy Markdown
Contributor Author

Unsure if I should mark this as breaking

@Uzaaft Uzaaft changed the title feat(editing-support): remove options and use plugin defaults feat(mcphub-nvim): Dont override opts. Jul 24, 2025
@Uzaaft

Uzaaft commented Jul 24, 2025

Copy link
Copy Markdown
Member

@jay-babu Please read the contribution guidelines so that I have to avoid always correct your PR titles.

@Uzaaft Uzaaft changed the title feat(mcphub-nvim): Dont override opts. feat(mcphub-nvim)!: Dont override opts Jul 24, 2025

@Uzaaft Uzaaft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Uzaaft

Uzaaft commented Jul 24, 2025

Copy link
Copy Markdown
Member

Marked PR as breaking since it will break previous setups.

@Uzaaft
Uzaaft merged commit f75b23e into AstroNvim:main Jul 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants