Code quality fix - Security - Array is stored directly #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For everything that's on the hot path (meaning not tests and things like config that's only instanciated once), this one is a big "no way". |
Contributor
There was a problem hiding this comment.
Not on hot path, why not.
Contributor
|
Sorry, I'm going to reject this one. I mainly develop AHC because I use it for Gatling. Copying everything around like this would definitively kill performance. Thanks anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of PMD rule pmd:ArrayIsStoredDirectly - “Security - Array is stored directly”.
You can find more information about the issue here: http://pmd.sourceforge.net/pmd-4.3.0/rules/sunsecure.html
Please let me know if you have any questions.
Faisal.