Code quality fix - Security - Array is stored directly #1039
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| package org.asynchttpclient.util; | ||
|
|
||
| import java.util.Arrays; | ||
|
|
||
| /** | ||
| * <p> | ||
| * Operations on arrays, primitive arrays (like {@code int[]}) and primitive | ||
| * wrapper arrays (like {@code Integer[]}). | ||
| * </p> | ||
| * <p/> | ||
| * <p> | ||
| * This class tries to handle {@code null} input gracefully. An exception will | ||
| * not be thrown for a {@code null} array input. | ||
| * </p> | ||
| */ | ||
| public final class ArrayUtils { | ||
|
|
||
| private ArrayUtils() { | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static boolean[] copyOf(final boolean[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static byte[] copyOf(final byte[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static short[] copyOf(final short[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static int[] copyOf(final int[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static long[] copyOf(final long[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static float[] copyOf(final float[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static double[] copyOf(final double[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static char[] copyOf(final char[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| /** | ||
| * <p> | ||
| * Return a copy of original array and handling {@code null}. | ||
| * </p> | ||
| * | ||
| * @param array | ||
| * the array to be copy, may be {@code null} | ||
| * @return a copy of the original array, {@code null} if {@code null} input | ||
| */ | ||
| public static <T> T[] copyOf(final T[] array) { | ||
| if (array == null) { | ||
| return null; | ||
| } | ||
| return Arrays.copyOf(array, array.length); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Copyright (c) 2013 Sonatype, Inc. All rights reserved. | ||
| * | ||
| * This program is licensed to you under the Apache License Version 2.0, | ||
| * and you may not use this file except in compliance with the Apache License Version 2.0. | ||
| * You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0. | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the Apache License Version 2.0 is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the Apache License Version 2.0 for the specific language governing permissions and limitations there under. | ||
| */ | ||
| package org.asynchttpclient; | ||
|
|
||
| import org.testng.Assert; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| public class DefaultRequestTest { | ||
|
|
||
| @Test | ||
| public void testByteData() { | ||
|
|
||
| byte[] actualByteData = "testData".getBytes(); | ||
|
|
||
| DefaultRequest request = new DefaultRequest(null, null, null, null, null, null, actualByteData, null, null, null, null, null, null, null, | ||
| null, 0, null, null, null, false, 0, 0, null, null, null); | ||
|
|
||
| /* | ||
| * Test references are different | ||
| */ | ||
| Assert.assertTrue(actualByteData != request.getByteData()); | ||
|
|
||
| /* | ||
| * Test array contents are same | ||
| */ | ||
| Assert.assertEquals(actualByteData, request.getByteData()); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on hot path, why not.