Skip to content

De conda#3

Merged
AtMostafa merged 2 commits into
mainfrom
de-conda
Jul 18, 2026
Merged

De conda#3
AtMostafa merged 2 commits into
mainfrom
de-conda

Conversation

@AtMostafa

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 18, 2026 10:07
@AtMostafa
AtMostafa merged commit c6b9213 into main Jul 18, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the conda-based installation path in favor of uv tool installation, and bumps the package version accordingly. It also deletes the conda environment YAML files that previously supported conda-based setup.

Changes:

  • Update README install instructions to focus on uv and remove the “Option B — conda” section.
  • Bump bnd version from 0.1.7 to 0.1.7.1.
  • Delete processing_env.yml and env.yml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
README.md Reworks setup docs to remove conda install option and emphasize uv install.
pyproject.toml Version bump to reflect the documentation/setup change.
processing_env.yml Removes the conda processing environment definition.
env.yml Removes the minimal conda environment definition.
Comments suppressed due to low confidence (1)

README.md:67

  • This PR deletes processing_env.yml and env.yml, but existing GitHub Actions workflows still reference them (.github/workflows/conda_processing_env_tests.yml uses conda env create --file=./processing_env.yml, and .github/workflows/condv_env_tests.yml uses conda env create --file=./env.yml). CI will fail until those workflows are updated/removed or replacement env files are reintroduced.
### 2. Set up Kilosort (separate conda env)

Kilosort runs in its own conda environment — `bnd` invokes it via `conda run -n kilosort ...`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
@AtMostafa
AtMostafa deleted the de-conda branch July 18, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants