Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the conda-based installation path in favor of uv tool installation, and bumps the package version accordingly. It also deletes the conda environment YAML files that previously supported conda-based setup.
Changes:
- Update README install instructions to focus on
uvand remove the “Option B — conda” section. - Bump
bndversion from0.1.7to0.1.7.1. - Delete
processing_env.ymlandenv.yml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Reworks setup docs to remove conda install option and emphasize uv install. |
| pyproject.toml | Version bump to reflect the documentation/setup change. |
| processing_env.yml | Removes the conda processing environment definition. |
| env.yml | Removes the minimal conda environment definition. |
Comments suppressed due to low confidence (1)
README.md:67
- This PR deletes
processing_env.ymlandenv.yml, but existing GitHub Actions workflows still reference them (.github/workflows/conda_processing_env_tests.ymlusesconda env create --file=./processing_env.yml, and.github/workflows/condv_env_tests.ymlusesconda env create --file=./env.yml). CI will fail until those workflows are updated/removed or replacement env files are reintroduced.
### 2. Set up Kilosort (separate conda env)
Kilosort runs in its own conda environment — `bnd` invokes it via `conda run -n kilosort ...`.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.