fix(core): resolve throttling race condition and optimize memory cache expiration - #1
Merged
Merged
Conversation
…e expiration - Add thread-safe lock to LocalThrottler to prevent concurrent semaphore re-instantiation - Harden GitHubCore context manager exit against None client calls - Refactor MemCache to passive O(1) expiration on lookup/set instead of O(N) linear sweep - Add unit tests in tests/test_unit_test/test_unit_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses critical concurrency, context management, and performance issues:
Thread-Safety in
LocalThrottler(githubkit/throttling.py):threading.Lockto guard lazy initialization of_semaphoreand_async_semaphore.max_concurrencylimit.Harden Context Manager Teardown in
GitHubCore(githubkit/core.py):__exit__and__aexit__to safely check for non-None client instances before calling.close()/.aclose().AttributeErrorcrashes during exception teardown.MemCache(githubkit/cache/mem_cache.py):get()lookups.Unit Test Coverage (
tests/test_unit_test/test_unit_test.py):Verification
Ran the unit test suite: