Conversation
Adds an opt-in closeOnBackdropClick prop to the shared Dialog component, off by default so every other dialog in the app keeps its current behavior — several (the "called" reminder, the moderation warning) deliberately force an explicit acknowledgment, and a stray backdrop click must not dismiss those. Enabled only on the ticket dialog, which is purely informational and has no confirmation to force. Detects the backdrop click the standard way for a native <dialog>: a click on the ::backdrop pseudo-element registers as a click on the <dialog> element itself (event.target === event.currentTarget), while a click on any actual content is a click on a descendant. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Clicking "Télécharger l'image" opened Safari's "View or Download" picker instead of saving directly — a known Safari quirk where a data: URL with an image MIME type on an <a download> link gets treated as content to preview, not a file to save, regardless of the download attribute. Switches from toPng (a data: URL) to toBlob + URL.createObjectURL. A blob: URL is what the download attribute reliably triggers a direct save for across Safari and other browsers. The object URL is revoked after a 1s delay rather than immediately after click() — revoking synchronously risks freeing it before the browser has actually started reading it, which Safari in particular can be slow to do. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.