Skip to content

add option status code log from origin#4

Merged
t4niwa merged 6 commits intomasterfrom
add-log-status-code
Nov 30, 2022
Merged

add option status code log from origin#4
t4niwa merged 6 commits intomasterfrom
add-log-status-code

Conversation

@t4niwa
Copy link
Copy Markdown
Contributor

@t4niwa t4niwa commented Nov 21, 2022

Description

add option status code log from origin

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Related issue/PR

Delete this section if there are no issues or pull requests that relate to this pull request.

  • Fixes #issue
  • Closes #PR

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

@t4niwa t4niwa changed the title [patch] add status code log from origin [patch] add option status code log from origin Nov 22, 2022
@t4niwa t4niwa force-pushed the add-log-status-code branch from a7223d8 to 1aa64ec Compare November 28, 2022 00:32
Comment thread test/data/example_config.yaml Outdated
Comment thread handler/handler.go Outdated
@t4niwa t4niwa force-pushed the add-log-status-code branch from f01fc61 to 93fe09a Compare November 28, 2022 08:26
@WindzCUHK
Copy link
Copy Markdown
Contributor

@t4niwa
Can help to add a unit test like below?

{
name: "check custom transport is used",
args: args{
cfg: config.Proxy{
Transport: config.Transport{
MaxIdleConnsPerHost: 442,
},
},
},
checkFunc: func(h http.Handler) error {
got := h.(*httputil.ReverseProxy).Transport.(*transport).RoundTripper.(*http.Transport).MaxIdleConnsPerHost
want := 442
if got != want {
return errors.Errorf("unexpected MaxConnsPerHost in custom transport, got: %v, want: %v", got, want)
}
return nil
},
},

Just check when cfg.OriginLog.StatusCode.Enable == true, got.ModifyResponse != nil is OK.

taniwa added 6 commits November 29, 2022 13:11
Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
fix
Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
@t4niwa t4niwa force-pushed the add-log-status-code branch from 05c12d6 to d3ba538 Compare November 29, 2022 04:12
@t4niwa t4niwa dismissed WindzCUHK’s stale review November 29, 2022 08:39

WindzCUHKさん不在のため

@kyfujisa
Copy link
Copy Markdown
Contributor

↑の指摘事項への対応が行われたことを確認しました。

@t4niwa t4niwa changed the title [patch] add option status code log from origin add option status code log from origin Nov 30, 2022
@t4niwa t4niwa merged commit 466a0a0 into master Nov 30, 2022
@t4niwa t4niwa deleted the add-log-status-code branch November 30, 2022 04:50
kyfujisa pushed a commit that referenced this pull request Feb 8, 2023
* add status-code log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add option for origin log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* fix

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add handler_test

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>
kyfujisa pushed a commit that referenced this pull request Feb 13, 2023
* add status-code log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add option for origin log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* fix

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add handler_test

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>
WindzCUHK added a commit that referenced this pull request Feb 14, 2023
* add option status code log from origin (#4)

* add status-code log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add option for origin log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* fix

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add handler_test

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* fix error & fatal in normal shutdown (#6)

* draft

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* bug fix: server error not appened

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add main unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* remove -

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* refactor: handle err for shared functionalities

Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>

* fix comment

Signed-off-by: wfan <wfan@yahoo-corp.jp>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Co-authored-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* add resource prefix config (#12)

* add resource prefix config

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* upgrade authorizer

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* upgrade go.mod

Signed-off-by: wfan <wfan@yahoo-corp.jp>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* new `noAuthPaths` option supporting wildcard characters (#15)

* draft

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix quote

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix empty regex

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* Update handler/error.go

Co-authored-by: ssunorz <42366422+ssunorz@users.noreply.github.com>
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: ssunorz <42366422+ssunorz@users.noreply.github.com>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add cert refresh period configulation

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add parse cert refresh period and Add Refresh logic

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Run cert refresh logic

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Load certificate

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add new server struct option

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TLSCertificateCache, New function

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move TLS config setting to authz_proxyd.go

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add comments

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move TLS cert invalid test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add WithTLSConfig test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move hash() function

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add enable / tlsConfig check

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add HTTPS server test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Use atomic.Value cache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add NewServer error test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add lock for update

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Delete comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TestNewTLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Implement test for authz_proxyd.New

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix typo

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add test for authz_proxyd.Start

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TestTLSCertificateCache_getCertificate

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TLSCertificateCache_RefreshCertificate template

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix param format for test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add refresh testcase(still in progress)

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* fix server.go unit test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Revert "Add refresh testcase(still in progress)"

This reverts commit fd9a578.

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Revert "Revert "Add refresh testcase(still in progress)""

This reverts commit f5003fd.

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Commentout work in progress test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix error message

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TestTLSCertificateCache_RefreshCertificate

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add CertRefreshPeriod 0 check

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add certRefreshPeriod option

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix test for config(add CertRefreshPeriod)

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix typo

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix typo

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix CertRefreshPeriod 0 check logic

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Remove dot

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Use NewTLSConfig in NewTLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Revert "Use NewTLSConfig in NewTLSConfigWithTLSCertificateCache"

This reverts commit 74006c8.

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Use NewTLSConfigWithTLSCertificateCache in NewTLSConfig

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move CertRefreshPeriod check to NewTLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix comment and log

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add process for compatibility

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix test for tls.go

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix condition for  running cert refresh daemon

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix tests for authz_proxyd_test.go

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix initialization

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix use modified config

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Remove TLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add not refreshed log

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

---------

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>
Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: t4niwa <114040262+t4niwa@users.noreply.github.com>
Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Co-authored-by: ssunorz <42366422+ssunorz@users.noreply.github.com>
Co-authored-by: Tomohiro Hirata - tomohira <tomohira@yahoo-corp.jp>
Co-authored-by: wfan <wfan@yahoo-corp.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants