Skip to content

fix error & fatal in normal shutdown#6

Merged
WindzCUHK merged 6 commits intomasterfrom
patch-fatal-log
Dec 7, 2022
Merged

fix error & fatal in normal shutdown#6
WindzCUHK merged 6 commits intomasterfrom
patch-fatal-log

Conversation

@WindzCUHK
Copy link
Copy Markdown
Contributor

@WindzCUHK WindzCUHK commented Dec 6, 2022

Description

fix error & fatal in normal shutdown

  1. remove
[ERR]:        (authz_proxyd.go:105):        pch: context canceled
[ERR]:        (authz_proxyd.go:123):        sch: [server: context canceled]
[FATAL]:        (/sd/workspace/src/github.com/AthenZ/authorization-proxy/main.go:172):
authorizerd: 1 times appeared: context canceled
server: context canceled
  1. add
[INFO]:        authorization proxy received signal: terminated
...
[INFO]:        authorization proxy main process shutdown success

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

Signed-off-by: wfan <wfan@yahoo-corp.jp>
wfan added 2 commits December 6, 2022 16:58
Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: wfan <wfan@yahoo-corp.jp>
@WindzCUHK
Copy link
Copy Markdown
Contributor Author

Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
@mlajkim
Copy link
Copy Markdown
Contributor

mlajkim commented Dec 7, 2022

I've refactored a part of code while you are on 1on1 @WindzCUHK

@ssunorz
Copy link
Copy Markdown
Contributor

ssunorz commented Dec 7, 2022

Comments are not correct.

// apiShutdown returns any error when shutdown the authorization proxy server.
// Before shutdown the authorization proxy server, it will sleep config.ShutdownDelay to prevent any issue from K8s

ssunorz
ssunorz previously approved these changes Dec 7, 2022
Signed-off-by: wfan <wfan@yahoo-corp.jp>
@WindzCUHK WindzCUHK merged commit 279622e into master Dec 7, 2022
@WindzCUHK WindzCUHK deleted the patch-fatal-log branch December 7, 2022 07:22
kyfujisa pushed a commit that referenced this pull request Feb 8, 2023
* draft

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* bug fix: server error not appened

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add main unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* remove -

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* refactor: handle err for shared functionalities

Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>

* fix comment

Signed-off-by: wfan <wfan@yahoo-corp.jp>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Co-authored-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>
kyfujisa pushed a commit that referenced this pull request Feb 13, 2023
* draft

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* bug fix: server error not appened

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add main unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* remove -

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* refactor: handle err for shared functionalities

Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>

* fix comment

Signed-off-by: wfan <wfan@yahoo-corp.jp>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Co-authored-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>
WindzCUHK added a commit that referenced this pull request Feb 14, 2023
* add option status code log from origin (#4)

* add status-code log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add option for origin log

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* update

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* fix

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

* add handler_test

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* fix error & fatal in normal shutdown (#6)

* draft

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* bug fix: server error not appened

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add main unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* remove -

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* refactor: handle err for shared functionalities

Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>

* fix comment

Signed-off-by: wfan <wfan@yahoo-corp.jp>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Co-authored-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* add resource prefix config (#12)

* add resource prefix config

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* upgrade authorizer

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* upgrade go.mod

Signed-off-by: wfan <wfan@yahoo-corp.jp>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* new `noAuthPaths` option supporting wildcard characters (#15)

* draft

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* add unit test

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix quote

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* fix empty regex

Signed-off-by: wfan <wfan@yahoo-corp.jp>

* Update handler/error.go

Co-authored-by: ssunorz <42366422+ssunorz@users.noreply.github.com>
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>

Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: ssunorz <42366422+ssunorz@users.noreply.github.com>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add cert refresh period configulation

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add parse cert refresh period and Add Refresh logic

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Run cert refresh logic

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Load certificate

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add new server struct option

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TLSCertificateCache, New function

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move TLS config setting to authz_proxyd.go

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add comments

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move TLS cert invalid test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add WithTLSConfig test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move hash() function

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add enable / tlsConfig check

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add HTTPS server test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Use atomic.Value cache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add NewServer error test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add lock for update

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Delete comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TestNewTLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Implement test for authz_proxyd.New

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix typo

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add test for authz_proxyd.Start

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TestTLSCertificateCache_getCertificate

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TLSCertificateCache_RefreshCertificate template

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix param format for test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add refresh testcase(still in progress)

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* fix server.go unit test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Revert "Add refresh testcase(still in progress)"

This reverts commit fd9a578.

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Revert "Revert "Add refresh testcase(still in progress)""

This reverts commit f5003fd.

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Commentout work in progress test

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix error message

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add TestTLSCertificateCache_RefreshCertificate

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add CertRefreshPeriod 0 check

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add certRefreshPeriod option

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix test for config(add CertRefreshPeriod)

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix typo

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix typo

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix comment

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix CertRefreshPeriod 0 check logic

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Remove dot

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Use NewTLSConfig in NewTLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Revert "Use NewTLSConfig in NewTLSConfigWithTLSCertificateCache"

This reverts commit 74006c8.

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Use NewTLSConfigWithTLSCertificateCache in NewTLSConfig

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Move CertRefreshPeriod check to NewTLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix comment and log

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add process for compatibility

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix test for tls.go

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix condition for  running cert refresh daemon

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix tests for authz_proxyd_test.go

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix initialization

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Fix use modified config

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Remove TLSConfigWithTLSCertificateCache

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

* Add not refreshed log

Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>

---------

Signed-off-by: taniwa <taniwa@yahoo-corp.jp>
Signed-off-by: Kyo Fujisaki <kyfujisa@yahoo-corp.jp>
Signed-off-by: wfan <wfan@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: t4niwa <114040262+t4niwa@users.noreply.github.com>
Co-authored-by: Windz <WindzCUHK@users.noreply.github.com>
Co-authored-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Co-authored-by: ssunorz <42366422+ssunorz@users.noreply.github.com>
Co-authored-by: Tomohiro Hirata - tomohira <tomohira@yahoo-corp.jp>
Co-authored-by: wfan <wfan@yahoo-corp.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants