Skip to content

fix error & fatal in normal shutdown for provider sidecar#5

Closed
mlajkim wants to merge 3 commits intomasterfrom
fix-error-&-fatal-in-normal-shutdown
Closed

fix error & fatal in normal shutdown for provider sidecar#5
mlajkim wants to merge 3 commits intomasterfrom
fix-error-&-fatal-in-normal-shutdown

Conversation

@mlajkim
Copy link
Copy Markdown
Contributor

@mlajkim mlajkim commented Dec 6, 2022

Description

fix error & fatal in normal shutdown for provider sidecar

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
Signed-off-by: Jeongwoo Kim - jekim <jekim@yahoo-corp.jp>
@mlajkim
Copy link
Copy Markdown
Contributor Author

mlajkim commented Dec 6, 2022

Decided to implement unit test on the wfan-san's branch, instead of this one.

@mlajkim mlajkim closed this Dec 6, 2022
@mlajkim
Copy link
Copy Markdown
Contributor Author

mlajkim commented Dec 6, 2022

wfan's branch
#6

@WindzCUHK WindzCUHK deleted the fix-error-&-fatal-in-normal-shutdown branch December 20, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant