Fix mini-map interaction, dragging/resizing and state reprojection logic#1
Merged
Merged
Conversation
Owner
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
updatePositionOnClickflag.showBaseMarker) did not create or remove the marker after initialization, causing inconsistencies when enabling/disabling it.Description
baseMarkermutable and implemented adidSetflow onshowBaseMarkerto dynamically create/remove the marker and reproject its position using cached scene state viacurrentBasePositionandcurrentSceneSize.handleClick(at:)so the delegate is only called whenupdatePositionOnClickis true.currentBasePosition,currentCameraPosition,currentCameraZoom, and ensuredupdateBasePositionandupdateCameraViewFrameupdate those caches for later reprojection.convertToMapPositionandconvertFromMapPosition) to guard against zero-sized scene/map dimensions and allow conversions when the node is detached by using cachedcurrentSceneSize.lastDragTime/lastResizeTimeat operation start to avoid premature stuck resets.mapSizechanges.Testing
swift testin this environment which could not complete due to the platform missing theSpriteKitframework (error: no such module 'SpriteKit'), so unit tests could not be executed here.Codex Task