Skip to content

Conversation

@AryazE
Copy link
Contributor

@AryazE AryazE commented Sep 12, 2024

Reference issue

None

What does this implement/fix?

This improves performance by transforming calculated into a set. As the only use is to check if a value is already calculated, keeping each value once is enough and it is faster to search in a set than a list.

Additional information

This issue was found by DyLin via auto-dylin.

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!! @AryazE

@AtsushiSakai AtsushiSakai merged commit 1f42140 into AtsushiSakai:master Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants