-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
implemented bipedal walking #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
also I have to moidfy README.md. |
Pull Request Test Coverage Report for Build 725
💛 - Coveralls |
|
This pull request introduces 3 alerts when merging 408d6f0 into bb8b8b3 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
@takayuki5168 Hi. Thank you again. Cool. I love your bipedal animation. |
|
@takayuki5168
|
AtsushiSakai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takayuki5168
2. Please fix LGTM errors. see reviews.
|
@takayuki5168 3. As you said, adding technical doc and updating README is better. |
Also, in this bipedal algorithm with inverted pendulum, the free leg is not considered. Only the support leg is considered. So it may be infeasible to display the free leg. I think current animation.gif is good to visualize what this planner is doing. |
|
|
@takayuki5168 Thank you for quick reply.
OK. I see. So, the current gif is OK.
Thanks.
OK. I will merge it now, so if you have a time to write the doc, please make another PR. I appreciate your great PR. Thank!! |
|
OK, thanks too! |
Sorry for postpone another my PR(#162)
I implemented bipedal walking with 3D Inverted Pendulum. How do you like this bipedal planner.
This time I put animation.gif, so I understand what I have to do next is doc.